Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Lisk network logos #29762

Merged
merged 2 commits into from
Jan 16, 2025
Merged

feat: add Lisk network logos #29762

merged 2 commits into from
Jan 16, 2025

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Jan 16, 2025

Description

Adds logos for the list network. Taken from #28763

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Add the lisk network (mainnet and testnet) from https://chainlist.org/?search=lisk&testnets=true
  2. Verify they have icons in the network selector

Screenshots/Recordings

Before

After

Screenshot 2025-01-16 at 10 56 14 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron enabled auto-merge January 16, 2025 19:29
@bergeron bergeron added this pull request to the merge queue Jan 16, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [e96463c]
Page Load Metrics (1813 ± 95 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39123921732368177
domContentLoaded15642300178218991
load15692335181319995
domInteractive258245168
backgroundConnect5115262813
firstReactRender16101612914
getState488262813
initialActions01000
loadScripts11571779133115977
setupStore65412147
uiStartup180628002211303146
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 372 Bytes (0.00%)

Merged via the queue into main with commit 08cc02f Jan 16, 2025
72 checks passed
@bergeron bergeron deleted the brian/list-logos branch January 16, 2025 20:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@metamaskbot metamaskbot added the release-12.11.1 Issue or pull request that will be included in release 12.11.1 label Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.1 Issue or pull request that will be included in release 12.11.1 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants