Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skips failing tests #29778

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Jan 17, 2025

Description

This test suite is failing for Firefox, and causing main to be red in CI, therefore we are skipping it for now and will come back to them later to fix them.
Reference slack thread.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the team-sol PRs from the Solana snap team label Jan 17, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@benjisclowder benjisclowder added this pull request to the merge queue Jan 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [0d96a9a]
Page Load Metrics (1585 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30619971521304146
domContentLoaded14451914155810952
load14712000158512158
domInteractive247936168
backgroundConnect887292412
firstReactRender1590432713
getState46012157
initialActions01000
loadScripts1039143611319546
setupStore65610115
uiStartup16492383183120297
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit 16ac089 Jan 17, 2025
81 checks passed
@benjisclowder benjisclowder deleted the SOL-skip-solana-e2e-test-temporarily branch January 17, 2025 12:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-sol PRs from the Solana snap team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants