Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate multichain assets rates controller to extension UI #30291

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Feb 13, 2025

Description

This PR aims to integrate the new multichainAssetsRatesControllers into the extension. To achieve this, an upgrade of the assets controller to version 49 is required. As a result, the target branch is set accordingly:
MetaMask PR #30250.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. open a flask build and add a solana account
  2. check if the polling for the rates is running

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

app/scripts/metamask-controller.js Outdated Show resolved Hide resolved
@salimtb salimtb force-pushed the salim/integrate-mutichain-assets-rates-controller branch from 6cd7757 to 48aa482 Compare February 13, 2025 15:52
@salimtb salimtb requested a review from GuillaumeRx February 13, 2025 16:11
@salimtb salimtb requested a review from GuillaumeRx February 14, 2025 09:20
@GuillaumeRx
Copy link
Contributor

Looking good 💯

Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to omit this state key from sentry

Base automatically changed from feat/bump-assets-controller-49.0.0 to main February 14, 2025 15:49
@salimtb salimtb marked this pull request as ready for review February 14, 2025 18:43
@metamaskbot
Copy link
Collaborator

Builds ready [04ae981]
Page Load Metrics (1883 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16422150188112962
domContentLoaded15802114184812862
load16432153188313364
domInteractive25124462813
backgroundConnect1070302010
firstReactRender1675332311
getState659242110
initialActions0452105
loadScripts11361603137010952
setupStore85919178
uiStartup18562333213514168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.33 KiB (0.02%)
  • ui: 0 Bytes (0.00%)
  • common: 49 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants