Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snaps): Add missing controller names to ControllersToInitialize #30301

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Feb 13, 2025

Description

This adds the missing controller names to ControllersToInitialize, types might need an update later has they don't fully support not having an initMessenger.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Feb 13, 2025
hmalik88
hmalik88 previously approved these changes Feb 13, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [0e6c8cb]
Page Load Metrics (1754 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15951994176912158
domContentLoaded15421944173212660
load15551994175413163
domInteractive259236147
backgroundConnect973242110
firstReactRender1691412512
getState583282412
initialActions01000
loadScripts11381463127610651
setupStore894192211
uiStartup178727902083244117
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GuillaumeRx GuillaumeRx dismissed stale reviews from FrederikBolding and hmalik88 February 13, 2025 18:32

Missing controllers, need to update

Mrtenz
Mrtenz previously approved these changes Feb 14, 2025
Mrtenz
Mrtenz previously approved these changes Feb 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [cbaaa9d]
Page Load Metrics (1557 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1489171115566230
domContentLoaded1470169715325426
load1489170715576230
domInteractive2480542110
backgroundConnect982292211
firstReactRender1580322412
getState35612147
initialActions00000
loadScripts1057121511114019
setupStore6431084
uiStartup16512073178111053
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 268 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner February 14, 2025 14:41
@metamaskbot
Copy link
Collaborator

Builds ready [5c677c4]
Page Load Metrics (1631 ± 82 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14592057164117484
domContentLoaded14482036161116981
load14592050163117082
domInteractive23119473014
backgroundConnect95527178
firstReactRender1575272010
getState45813168
initialActions01000
loadScripts10181456116513464
setupStore55715168
uiStartup16652240184518890
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 268 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants