-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(snaps): Add missing controller names to ControllersToInitialize
#30301
Open
GuillaumeRx
wants to merge
10
commits into
main
Choose a base branch
from
gr/add-missing-controler-init-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
hmalik88
reviewed
Feb 13, 2025
FrederikBolding
previously approved these changes
Feb 13, 2025
hmalik88
previously approved these changes
Feb 13, 2025
FrederikBolding
previously approved these changes
Feb 13, 2025
Builds ready [0e6c8cb]
Page Load Metrics (1754 ± 63 ms)
Bundle size diffs
|
Missing controllers, need to update
Mrtenz
previously approved these changes
Feb 14, 2025
Mrtenz
previously approved these changes
Feb 14, 2025
Builds ready [cbaaa9d]
Page Load Metrics (1557 ± 30 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [5c677c4]
Page Load Metrics (1631 ± 82 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the missing controller names to
ControllersToInitialize
, types might need an update later has they don't fully support not having aninitMessenger
.Related issues
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist