Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove circular dependency between actions.ts and swaps.util.ts #30306

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Feb 13, 2025

This PR solves an issue with circular dependencies. It does not change the behavior of the application. It only rearranges functions/files to avoid circular references.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 13, 2025
@davidmurdoch davidmurdoch changed the title refactor: remove circular dependency between actions.ts and swaps.utils.ts refactor: remove circular dependency between actions.ts and swaps.util.ts Feb 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [4419bb8]
Page Load Metrics (1647 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36818991570296142
domContentLoaded14471864162011153
load14611903164711756
domInteractive19135382713
backgroundConnect871302110
firstReactRender1466282010
getState421942
initialActions00000
loadScripts1003138211688842
setupStore764222110
uiStartup16752411190316880
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 432 Bytes (0.00%)

@davidmurdoch davidmurdoch marked this pull request as ready for review February 14, 2025 19:01
@davidmurdoch davidmurdoch requested review from a team, HowardBraham and dbrans as code owners February 14, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-extension-platform Extension Platform team
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

3 participants