Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revisit list of currencies #30324

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Feb 14, 2025

Description

The purpose of this PR is to review and align the currency list with the options available in our price API. If a user has already chosen a currency that no longer appears in the updated list, they will be automatically migrated to USD.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to main and choose any currency not available on the new list
  2. Switch the branch
  3. you should see usd

Screenshots/Recordings

Before

After

Screenshot 2025-02-14 at 16 05 05

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb marked this pull request as ready for review February 14, 2025 15:05
@metamaskbot
Copy link
Collaborator

Builds ready [b0b8de3]
Page Load Metrics (1602 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13971833160412761
domContentLoaded13751781156913063
load14281832160212058
domInteractive2391392210
backgroundConnect106429199
firstReactRender1592362512
getState56014168
initialActions00000
loadScripts9641319113511053
setupStore56611136
uiStartup16182241185617282
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.65 KiB (0.03%)
  • ui: -2 KiB (-0.03%)
  • common: 1.74 KiB (0.02%)

@metamaskbot
Copy link
Collaborator

Builds ready [92b38df]
Page Load Metrics (1572 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14361942157412158
domContentLoaded14231921154711857
load14321941157212057
domInteractive238438178
backgroundConnect969282010
firstReactRender1473392412
getState44713126
initialActions01000
loadScripts996139511279747
setupStore66415178
uiStartup16332238178014067
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.2 KiB (0.04%)
  • ui: -265 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@salimtb salimtb changed the title fix: process the migration only if 1 infura rpc exists fix: revisit list of currencies Feb 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [6ba522f]
Page Load Metrics (2153 ± 138 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42025691952527253
domContentLoaded173830202120289139
load179030302153288138
domInteractive28162724019
backgroundConnect12102392613
firstReactRender18243534823
getState6107272512
initialActions01000
loadScripts122523651575245118
setupStore865282210
uiStartup210140292533442212
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.22 KiB (0.04%)
  • ui: -265 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants