Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (cherry-pick): add Runway to CLA Allowlist (#30302) #30340

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Feb 14, 2025

Cherry picks f7f2769 to v12.12

Description

Open in GitHub Codespaces

This PR adds runway-github[bot] to the CLA allowlist, as this github action recently failed on the v12.12.0 release branch, presumably because it was missing.

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/actions/runs/13304016671/job/37176762833

Manual testing steps

  1. After merging, CLA signature should pass, even if Runway automations contribute to a release.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30302?quickstart=1)

This PR adds `runway-github[bot]` to the CLA allowlist, as this github
action [recently failed on the v12.12.0 release
branch](https://github.com/MetaMask/metamask-extension/actions/runs/13304016671/job/37176762833),
presumably because it was missing.

## **Related issues**

Fixes:
https://github.com/MetaMask/metamask-extension/actions/runs/13304016671/job/37176762833

## **Manual testing steps**

1. After merging, CLA signature should pass, even if Runway automations
contribute to a release.

## **Screenshots/Recordings**

Not applicable

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 14, 2025
@danjm danjm changed the title fix: add Runway to CLA Allowlist (#30302) fix (cherry-pick): add Runway to CLA Allowlist (#30302) Feb 14, 2025
@danjm danjm merged commit ce854b0 into Version-v12.12.0 Feb 14, 2025
38 of 40 checks passed
@danjm danjm deleted the cherry-pick-f7f2769ad37-v12.12 branch February 14, 2025 17:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants