Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: make Git blame ignore specified large refactor and lint commits #30661

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented Mar 1, 2025

Description

@davidmurdoch requested this feature here: #30440 (review)

Also adds to the VSCode GitLens settings. If a Cursor user could help with the Cursor settings, that would be much appreciated.

We should discuss:

  • The inclusion of Added storybook check to CI #17092, as I'm undecided about it
  • Whether it's appropriate to automatically execute git config blame.ignoreRevsFile .git-blame-ignore-revs in postinstall. It writes to the local .git/config file in your metamask-extension folder, so it's only changing that one folder.

Command to get commits with over 200 file changes

git log --pretty=format:"%H %s" --shortstat | awk '{if ($1 ~ /^[0-9]+$/) {num = $1 + 0; if (num > 200 && current_hash !~ /Revert/) print num " " current_hash} else current_hash = $0}' | sort -nr

Open in GitHub Codespaces

Related issues

David Murdoch request: #30440 (review)

Ignored PRs

@HowardBraham HowardBraham self-assigned this Mar 1, 2025
Copy link
Contributor

github-actions bot commented Mar 1, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-tiger Tiger team (for tech debt reduction + performance improvements) label Mar 1, 2025
@HowardBraham HowardBraham marked this pull request as ready for review March 1, 2025 00:57
@@ -10,7 +10,7 @@
"webpack": "tsx ./development/webpack/launch.ts",
"webpack:clearcache": "./development/clear-webpack-cache.js",
"foundryup": "tsx ./test/helpers/foundry/foundryup.ts",
"postinstall": "yarn webpack:clearcache && yarn foundryup",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loose opinion: I think gitlens might be fine, but not postinstall for everyone

Co-authored-by: David Murdoch <[email protected]>
@metamaskbot
Copy link
Collaborator

Builds ready [552198a]
Page Load Metrics (1479 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint54817061443221106
domContentLoaded1369168914607938
load1373170714798240
domInteractive2383382110
backgroundConnect106827157
firstReactRender146327209
getState45313157
initialActions01000
loadScripts985122310826732
setupStore74714147
uiStartup1559191716669144
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham added team-extension-platform Extension Platform team and removed team-tiger Tiger team (for tech debt reduction + performance improvements) labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants