-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: make Git blame ignore specified large refactor and lint commits #30661
Open
HowardBraham
wants to merge
2
commits into
main
Choose a base branch
from
git-blame-ignore-revs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
davidmurdoch
reviewed
Mar 1, 2025
@@ -10,7 +10,7 @@ | |||
"webpack": "tsx ./development/webpack/launch.ts", | |||
"webpack:clearcache": "./development/clear-webpack-cache.js", | |||
"foundryup": "tsx ./test/helpers/foundry/foundryup.ts", | |||
"postinstall": "yarn webpack:clearcache && yarn foundryup", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loose opinion: I think gitlens might be fine, but not postinstall for everyone
davidmurdoch
reviewed
Mar 1, 2025
Co-authored-by: David Murdoch <[email protected]>
Builds ready [552198a]
Page Load Metrics (1479 ± 40 ms)
Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@davidmurdoch requested this feature here: #30440 (review)
Also adds to the VSCode GitLens settings. If a Cursor user could help with the Cursor settings, that would be much appreciated.
We should discuss:
git config blame.ignoreRevsFile .git-blame-ignore-revs
inpostinstall
. It writes to the local.git/config
file in yourmetamask-extension
folder, so it's only changing that one folder.Command to get commits with over 200 file changes
Related issues
David Murdoch request: #30440 (review)
Ignored PRs
sass
to v1.71.0 #22531