Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add e2e tests for blockaid validations on re-designed signature request pages #13075

Open
wants to merge 30 commits into
base: personal_sign_e2e
Choose a base branch
from
Open

chore: Add e2e tests for blockaid validations on re-designed signature request pages #13075

wants to merge 30 commits into from
+295 −118

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 20, 2025

Description

Add e2e tests for blockaid validations on re-designed signature request pages

Related issues

Fixes: #13073

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jan 20, 2025
@jpuri jpuri requested a review from a team as a code owner January 20, 2025 11:49
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri marked this pull request as draft January 20, 2025 12:40
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 20, 2025
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 20, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@MetaMask MetaMask deleted a comment from github-actions bot Jan 20, 2025
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 20, 2025
@MetaMask MetaMask deleted a comment from github-actions bot Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6618dc2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/724befaf-f7d9-4276-b06f-728b8c476b39

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri
Copy link
Contributor Author

jpuri commented Jan 22, 2025

PR to be rebased once #13092 is merged

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c2aa868
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d42f5983-4a47-4a2a-b142-cc4991100fb3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri marked this pull request as ready for review January 22, 2025 05:22
@jpuri jpuri requested review from a team as code owners January 22, 2025 05:22
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f1cb688
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b64a8718-b7c7-4644-91e6-17f0903d6b5c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

jpuri
jpuri commented Jan 22, 2025
View reviewed changes
app/components/UI/Navbar/index.js
@@ -601,9 +601,10 @@ export function getSendFlowTitle(
canGoBack ? (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the files changed in this PR are only formatting changes.

@jpuri jpuri removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 22, 2025
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 81db572
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8c0079a3-9ff1-4d5f-8189-0f45b950bf88

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 22, 2025
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 060e27e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5a3a820a-3e37-4de0-bd31-1d466bfcdb5b

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
43.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpuri