Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(4469): networks with activity integration #14348

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Apr 1, 2025

Description

Important: This integration is dependent on this PR and a multichain network controller update

This PR updates the multichain network controller to implement the new getNetworksWithActivityByAccounts method from our core library and adds the necessary state management.

Related issues

Related to #4469

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Screenshot 2025-04-01 at 12 33 34 PM

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…m the multichain networks controller and added the relevant state updates for mocks/fixtures
Copy link
Contributor

github-actions bot commented Apr 1, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward marked this pull request as ready for review April 1, 2025 18:38
@vinnyhoward vinnyhoward requested review from a team as code owners April 1, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants