Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove exports from package.json #1161

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: remove exports from package.json #1161

wants to merge 3 commits into from

Conversation

chakra-guy
Copy link
Collaborator

@chakra-guy chakra-guy commented Dec 10, 2024 •
edited
Loading

Explanation

This PR removes the exports field from the Metamask SDK package.json to resolve build issues experienced in Next.js + Wagmi integrations. It also upgrades TypeScript to ensure compatibility and maintain stable compilation after removing the exports configuration.

References

No specific issue references.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@chakra-guy chakra-guy added the deploy Deploys the test dapps label Dec 10, 2024
@chakra-guy chakra-guy marked this pull request as ready for review December 11, 2024 09:41
@chakra-guy chakra-guy requested a review from a team as a code owner December 11, 2024 09:41
BjornGunnarsson
BjornGunnarsson previously approved these changes Dec 11, 2024
View reviewed changes
Copy link

@BjornGunnarsson BjornGunnarsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a bump in TS version.

@christopherferreira9 christopherferreira9 mentioned this pull request Dec 11, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BjornGunnarsson BjornGunnarsson BjornGunnarsson left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
deploy Deploys the test dapps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chakra-guy @BjornGunnarsson @christopherferreira9