-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(security): remove GitHub Actions caching to prevent cache poisoning #1209
base: main
Are you sure you want to change the base?
Conversation
Updated the publish-release GitHub Actions workflow to use newer versions of actions and removed the dry-run step for npm publish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't understand this. If files are cached, surely their checksumms are verified after downloading. If so it doesn't matter if it's cached or not, so it can be cached for perf reasons. No? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
=======================================
Coverage 74.05% 74.05%
=======================================
Files 182 182
Lines 4351 4351
Branches 1066 1066
=======================================
Hits 3222 3222
Misses 1129 1129 ☔ View full report in Codecov by Sentry. |
|
Description
Context
This PR updates our GitHub Actions workflows to use artifacts instead of caching for better control over build outputs. The changes affect the
lint-build-test.yml
andpublish-release.yml
workflows.Changes
cache: yarn
configurations from all Node.js setup steps inlint-build-test.yml
publish-release.yml
workflow to:checkout@v4
,setup-node@v4
)upload-artifact@v4
anddownload-artifact@v4
Implementation Details
This change replaces the GitHub Actions caching mechanism with artifacts for managing build outputs between jobs. This provides more explicit control over how build artifacts are handled and transferred throughout the workflow.
Performance Considerations
Build times may slightly increase without caching, but the artifact implementation ensures efficient transfer of build outputs between jobs. We can monitor and optimize if needed.
Breaking Changes
None. This is an internal workflow change that doesn't affect the published packages or their consumers.
Testing Instructions
Related Issues
#3925 - Remove usage of GitHub action caching from critical workflows