Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds missing analytics data to all tracking events #552

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

andreahaku
Copy link
Contributor

@andreahaku andreahaku commented Nov 27, 2023

Adds missing analytics data to all tracking events. Specifically:

  • url
  • title
  • platform
  • source
  • sdkVersion

It also adds a Redis server to the architecture where those data are temporarily stored (for up to 30 days) based on the hash of the room id.

It also removes the use of LRUCache used for performance improvement to store the hash of the room id and uses Redis for it as well.

@andreahaku andreahaku requested a review from a team as a code owner November 27, 2023 10:04
@andreahaku andreahaku changed the title Adds missing analytics data to all tracking events feat: Adds missing analytics data to all tracking events Nov 27, 2023
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
ioredis 5.3.2 network +7 846 kB ioredis-robot

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Network access ioredis 5.3.2

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

omridan159
omridan159 previously approved these changes Nov 28, 2023
@andreahaku andreahaku force-pushed the feature/socketio_ts_refactor branch from 1844732 to 607c00a Compare December 4, 2023 11:15
Base automatically changed from feature/socketio_ts_refactor to main December 4, 2023 11:43
@christopherferreira9 christopherferreira9 dismissed omridan159’s stale review December 4, 2023 11:43

The base branch was changed.

andreahaku and others added 6 commits December 4, 2023 13:53
* feat: release 44.0.0

* chore: changelogs
* feat: refactors code to TypeScript, adds unit tests and improved loggin

* feat: updates missing yarn.lock and README.md with additional instructions
@andreahaku andreahaku force-pushed the feature/socketio_missing_analytics branch from 52e50a0 to 1b263d4 Compare December 4, 2023 12:54
Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 merged commit 55c1dd3 into main Dec 6, 2023
@christopherferreira9 christopherferreira9 deleted the feature/socketio_missing_analytics branch December 6, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants