Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds the bootstrap of the E2E tests #585

Merged
merged 23 commits into from
Dec 14, 2023

Conversation

christopherferreira9
Copy link
Collaborator

There is some unused code for dapps that aren't being tested yet but this should serve as a foundation for the E2E initiative.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner December 13, 2023 14:42
omridan159
omridan159 previously approved these changes Dec 13, 2023
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Deprecated koa-compose 4.2.0
  • Reason: [email protected] is a breaking version, please either use <= v4.1 or upgrade to v5.x once it is released
New author koa-compose 4.2.0
Non-existent author buffers 0.1.1
Non-existent author chainsaw 0.1.0
Non-existent author traverse 0.3.9
Network access basic-ftp 5.0.3
Network access pac-proxy-agent 7.0.1
Network access @tootallnate/quickjs-emscripten 0.23.0
Network access edgedriver 5.3.9
Network access @puppeteer/browsers 1.9.0
Shell access @puppeteer/browsers 1.9.0
Network access axios 1.6.2
Network access browserstack-local 1.5.5
Shell access browserstack-local 1.5.5
Network access get-uri 6.0.2
Network access proxy-agent 6.3.1
Network access wait-port 1.1.0
Network access koa 2.14.2
New author mute-stream 1.0.0
New author koa-convert 2.0.0
New author cacheable-lookup 7.0.0
New author binary 0.3.0
New author only 0.0.2
New author normalize-package-data 6.0.0
New author get-stream 8.0.1
New author recursive-readdir 2.2.3
Shell access locate-app 2.1.0

Next steps

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is a non-existent author?

The package was published by an npm account that no longer exists.

Packages should have active and identified authors.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments to make it more "maintainable"

e2e/README.md Show resolved Hide resolved
e2e/src/Gestures.ts Show resolved Hide resolved
e2e/src/Utils.ts Outdated Show resolved Hide resolved
e2e/src/screens/Dapps/NextJSDappScreen.ts Show resolved Hide resolved
omridan159
omridan159 previously approved these changes Dec 14, 2023
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 merged commit 6ac8e55 into main Dec 14, 2023
1 of 2 checks passed
@christopherferreira9 christopherferreira9 deleted the feature/e2e_bootstrap branch December 14, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants