Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes missing tsc dependency #586

Merged
merged 6 commits into from
Dec 19, 2023
Merged

fix: fixes missing tsc dependency #586

merged 6 commits into from
Dec 19, 2023

Conversation

andreahaku
Copy link
Contributor

@andreahaku andreahaku commented Dec 13, 2023 •
edited
Loading

Fixes missing tsc dependency installation in CI/CD when deploying socket.io server

@andreahaku andreahaku requested a review from a team as a code owner December 13, 2023 16:32
elefantel
elefantel previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@elefantel elefantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andreahaku andreahaku marked this pull request as draft December 14, 2023 15:26
@andreahaku andreahaku force-pushed the fix/dockerfile_missing_tsc branch from a7647dd to 1269b44 Compare December 14, 2023 18:29
@andreahaku andreahaku force-pushed the fix/dockerfile_missing_tsc branch from 1269b44 to 224177c Compare December 19, 2023 11:21
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f373377) 79.96% compared to head (4c72f0a) 79.96%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #586   +/-   ##
=======================================
  Coverage   79.96%   79.96%           
=======================================
  Files         170      170           
  Lines        3524     3524           
  Branches     1011     1011           
=======================================
  Hits         2818     2818           
  Misses        706      706

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@socket-security Socket Security
Copy link

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/node 20.9.4...20.10.4 None +0/-0 3.93 MB types
nodemon 2.0.22...3.0.2 None +0/-0 211 kB remy

🚮 Removed packages: @types/[email protected], @types/[email protected]

@andreahaku andreahaku marked this pull request as ready for review December 19, 2023 16:22
@andreahaku andreahaku requested a review from elefantel December 19, 2023 16:22
@christopherferreira9 christopherferreira9 requested a review from a team December 19, 2023 16:31
christopherferreira9
christopherferreira9 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku merged commit e2773a8 into main Dec 19, 2023
30 checks passed
@andreahaku andreahaku deleted the fix/dockerfile_missing_tsc branch December 19, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherferreira9 christopherferreira9 christopherferreira9 approved these changes

@elefantel elefantel Awaiting requested review from elefantel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreahaku @elefantel @christopherferreira9