Skip to content

Feat/mm mobile #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Feat/mm mobile #4

wants to merge 10 commits into from

Conversation

ieow
Copy link
Collaborator

@ieow ieow commented Apr 17, 2025 •
edited
Loading

Motivation and Context

Jira Link:

Description

MM is using compileSDK 34 with yarn 1.22.22
this pr is to patch the package so that it to works with
compileSDK 34
Java 1.1
yarn 1.22.22

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@socket-security Socket Security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Addednpm/​react-native-builder-bob@​0.38.4971007498100
Addednpm/​@​babel/​traverse--for-generate-function-map@​7.27.0100100100100100

View full report

@ieow ieow mentioned this pull request Apr 17, 2025
Closed
9 tasks
chaitanyapotti
chaitanyapotti approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ieow ieow mentioned this pull request Apr 17, 2025
Closed
9 tasks
@ieow ieow marked this pull request as ready for review April 17, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ieow @chaitanyapotti