chore: validate that custodians did not change parameters when signing #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-t
force-pushed
the
MMM-XXX-tx-nonce
branch
2 times, most recently
from
76c5179 to
0eeba0f
Compare
shane-t
force-pushed
the
MMM-XXX-tx-nonce
branch
from
0eeba0f to
09f909b
Compare
shane-t
force-pushed
the
MMM-XXX-tx-nonce
branch
from
09f909b to
7b31499
Compare
PatrykLucka
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error is now shown (and transaction rejected) when the custodian returns a
signedRawTransactionthat would not be the same as the message MetaMask expects to be signed