fix: ens resolution only supported on mainnet #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and fixed mainnet ENS util test
k-g-j
changed the title
owencraston
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only support ENS resolution when the user is on mainnet. Check currently selected chain ID in Snap homepage and notify the user that ENS is only available on mainnet. If user is not on mainnet, and inputs an ENS name, the snap will show the error message "ENS is only supported on Ethereum mainnet"
fixes: https://github.com/MetaMask/accounts-planning/issues/402
Demo
Screen.Recording.2024-05-01.at.12.29.29.PM.mov