perf: Encode messages in mobile as byte arrays #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
changed the title
FrederikBolding
changed the title
FrederikBolding
force-pushed
the
fb/mobile-perf-pass
branch
from
10ecf5d to
8154a56
Compare
Mrtenz
reviewed
Feb 11, 2025
| @@ -22,12 +22,12 @@ describe('WebViewMessageStream', () => { | |||
| expect(await responsePromise).toBe(555); | |||
|
|
|||
| expect(mockWebViewA.injectJavaScript).toHaveBeenCalledWith( | |||
| `window.postMessage('eyJ0YXJnZXQiOiJiIiwiZGF0YSI6MTExfQ==')`, | |||
| `window.postMessage([123,34,116,97,114,103,101,116,34,58,34,98,34,44,34,100,97,116,97,34,58,34,83,89,78,34,125])`, | |||
There was a problem hiding this comment.
Is the size increase not of concern? Does this work with very large Snap bundles etc.?
There was a problem hiding this comment.
Actually posting the message is slightly slower yes, but we save a lot of time encoding/decoding. Seems worth it even with the size increase.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3077 +/- ##
==========================================
- Coverage 94.88% 94.88% -0.01%
==========================================
Files 506 506
Lines 11121 11120 -1
Branches 1708 1708
==========================================
- Hits 10552 10551 -1
Misses 569 569 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Feb 12, 2025
FrederikBolding
force-pushed
the
fb/mobile-perf-pass
branch
from
8154a56 to
b20df4f
Compare
FrederikBolding
force-pushed
the
fb/mobile-perf-pass
branch
from
b20df4f to
7c7c37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base64 encoding/decoding seems to be a significant overhead for the boot message on mobile. Encoding the messages as bytes instead have proven to be more performant, but still has overhead.