Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for parquet reading #21

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Updates for parquet reading #21

merged 2 commits into from
Dec 23, 2023

Conversation

KIwabuchi
Copy link
Collaborator

@KIwabuchi KIwabuchi commented Dec 23, 2023 •
edited
Loading

  • Remove a wrong assert statement (triggered when MetallData is built with the debug mode).
  • Require Arrow v14
  • Remove the unused parquet reading bench program
  • Some code brush up

This code depends on LLNL/ygm#191 to read int32 and float values in parquet files.

CI will fail because this PR does not fix the missing boost unordered_map.hpp error.

@KIwabuchi
Updates for parquet reading
f8ed139 
- Remove an unused parquet reading bench program
- Require Arrow v14
- Remove a wrong assert statment
- Some code brush up
@KIwabuchi
Brush up on CMake File
6d7ff1b
@KIwabuchi KIwabuchi merged commit e9aac75 into MetallData:master Dec 23, 2023
1 check failed
@KIwabuchi KIwabuchi deleted the feature/parquet branch December 23, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KIwabuchi