Removed strategy brainfuck and turned it into a more proper solution. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long story short: PathingRuleSet nolonger maintains the PathfinderStrategy. It is now passed via the Pathfinder.findPath method. With this change we grant the Pathfinder and -strategies more flexibility
|
I had a look through... So I thought that the thought process before was to avoid having the user creating a tonne of throwaway strategy objects. Also, if the contact with the user is the expectation that each path find will have a new strategy, why is it that it defaults to a common instance. I suppose that it doesn't really matter for direct. |
olijeffers0n
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short: PathingRuleSet nolonger maintains the PathfinderStrategy. It is now passed via the Pathfinder.findPath method. With this change we grant the Pathfinder and -strategies more flexibility