Fix topic label for Kafka metrics

MeteoGroup · Mar 8, 2017 · 61fe000 · 61fe000
1 parent 9452edb
commit 61fe000
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/amqp-to-kafka.go b/amqp-to-kafka.go
@@ -93,7 +93,7 @@ func forwardToKafka(delivery amqp.Delivery, kafkaProducer Producer) (forwarded [
     messageCounter.WithLabelValues("skipped").Inc()
   } else {
     forwarded = append(forwarded, delivery)
-    kafkaOffsets.WithLabelValues(strconv.FormatInt(int64(partition), 10)).Set(float64(offset))
+    kafkaOffsets.WithLabelValues(kafkaTopic, strconv.FormatInt(int64(partition), 10)).Set(float64(offset))
     messageCounter.WithLabelValues("forwarded").Inc()
   }
   return

diff --git a/metrics.go b/metrics.go
@@ -24,8 +24,8 @@ import (
 var messageCounter = prometheus.NewCounterVec(prometheus.CounterOpts{Name:"messages", Help: "Messages handled"}, []string{"state"})
 var kafkaOffsets = prometheus.NewGaugeVec(prometheus.GaugeOpts{
   Name:"kafka_offset", Help: "Last known Kafka offsets",
-  ConstLabels: prometheus.Labels{"topic": kafkaTopic, "direction": "produced"},
-}, []string{"partition"})
+  ConstLabels: prometheus.Labels{"direction": "produced"},
+}, []string{"topic", "partition"})
 
 func startPrometheusHttpExporter() {
   if metricsAddress == "" {

diff --git a/test/docker-compose.yml b/test/docker-compose.yml
@@ -11,7 +11,6 @@ services:
     environment:
     - AMQP_URI=amqp://amqp
     - AMQP_EXCHANGE=public
-    - AMQP_QUEUE=
     - AMQP_BINDING_KEY=/messages
     - AMQP_CONSUMER_TAG=my-tag
     - KAFKA_BROKERS=kafka:9092