Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shape files, pre-commits, scaling function and Readme #34

Merged
merged 42 commits into from
Dec 21, 2023
Merged

Shape files, pre-commits, scaling function and Readme #34

merged 42 commits into from
Dec 21, 2023

Conversation

Karko93
Copy link
Contributor

@Karko93 Karko93 commented Dec 11, 2023

This PR contains following changes:

  • Implemented feature to generate shape files and updated unit tests
  • Removed several pre-commit errors from the past
  • Updated the ReadMe for more clarification
  • option to scale the field values

Karko93 and others added 27 commits August 17, 2023 11:54
@Karko93
Class to save plots and data in different file formats
7173b55
@Karko93
File formatter sorts files with multiple extension
b9d4b6f
@Karko93
Add species_name as possible parameter for naming output files
38add7a
@Karko93
Add multiplier command to scale the output data
1ccab32
@Karko93
Code clean-up
d576e22
@Karko93
Add functionality to generate shape files
799cc42
@Karko93
Code Clean Up
9cdaceb
@Karko93
Code Format
42d1e2e
@Karko93
Update ReadMe
2000227
@Karko93
Code Cleanup and Formatting
38172eb
@Karko93
Clean up code
a6e99be
@Karko93
Update Jenkins test steps
dcbe1c4
@Karko93
docstyle, spelling and flake8 clean up
5cc3afb
@Karko93
Add default output path (root results in IOErrors)
1864dae
@Karko93
Pre-commit Clean-up
0ac7f23
@Karko93
Moved coordinate transformation function
2580a0c
@Karko93
Update References
7c1180b
@Karko93
Restructure code
1b8c435
@Karko93
Init shape file tests
e01899c
@Karko93
Add Unit test for shape files
2fb3605
@Karko93
Clean up
0b99792
@Karko93
Update Text
aa64715
@Karko93
Add data from test files
bf4666f
@Karko93
Add example png
0c65866
@Karko93
Update README.md
5524503
@Karko93
Update README.md
6aa3230 
Add Key feature section and update reference instrution
@Karko93
Removed typo
2bb341f
@Karko93
Copy link
Contributor Author

Karko93 commented Dec 11, 2023

Remark: A large sample of test shape files were sent to the customer and compared with the corresponding .pdf files.
No differences have been found and the data structure was approved to their workflow.

cfkanesan
cfkanesan reviewed Dec 12, 2023
View reviewed changes
Copy link

@cfkanesan cfkanesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you review the noqa: E501? Many are not needed due to the auto formatting I suppose

src/pyflexplot/save_data.py Show resolved Hide resolved
src/pyflexplot/save_data.py Outdated Show resolved Hide resolved
src/pyflexplot/save_data.py Outdated Show resolved Hide resolved
src/pyflexplot/save_data.py Show resolved Hide resolved
src/pyflexplot/save_data.py Outdated Show resolved Hide resolved
src/pyflexplot/data_transformation/rotated_pole.py Outdated Show resolved Hide resolved
src/pyflexplot/cli/main.py Outdated Show resolved Hide resolved
src/pyflexplot/cli/main.py Outdated Show resolved Hide resolved
src/pyflexplot/cli/main.py Outdated Show resolved Hide resolved
src/pyflexplot/cli/main.py Outdated Show resolved Hide resolved
@Karko93
Copy link
Contributor Author

Karko93 commented Dec 15, 2023

So, every single comment besides one is resolved. May I merge?

@cfkanesan
Copy link

So, every single comment besides one is resolved. May I merge?

I'm having a second look.

pirmink
pirmink reviewed Dec 15, 2023
View reviewed changes
src/pyflexplot/plots.py Outdated Show resolved Hide resolved
@Karko93
Copy link
Contributor Author

Karko93 commented Dec 19, 2023

  • Every comment is resolved now
  • Merge Conflict with the ReadME is solved
  • Pre-commit hook checks suceed besides some annotations
    May I merge?

@Karko93 Karko93 merged commit 43645c4 into main Dec 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirmink pirmink pirmink left review comments

@cfkanesan cfkanesan cfkanesan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Karko93 @cfkanesan @pirmink