Refactor remove_articles()

Fix so it's doesn't return lowered results, and *only* removes articles

darkseid/utils.py

@@ -43,20 +43,11 @@ def remove_articles(text: str) -> str:
 
     :param str text: A string with articles (ex. 'and', 'a', 'the').
     """
-    text = text.lower()
-    articles: List[str] = ["and", "a", "&", "issue", "the"]
-    new_text: str = ""
-    for word in text.split(" "):
-        if word not in articles:
-            new_text += word + " "
+    articles = ["and", "a", "&", "issue", "the"]
+    new_text = "".join(word + " " for word in text.split(" ") if word.lower() not in articles)
 
     new_text = new_text[:-1]
 
-    # now get rid of some other junk
-    new_text = new_text.replace(":", "")
-    new_text = new_text.replace(",", "")
-    new_text = new_text.replace("-", " ")
-
     return new_text
 
 

tests/test_darkseid_utils.py

@@ -5,7 +5,14 @@
 
 def test_remove_articles():
     txt = "The Champions & Inhumans"
-    expected_result = "champions inhumans"
+    expected_result = "Champions Inhumans"
+    result = utils.remove_articles(txt)
+    assert result == expected_result
+
+
+def test_removes_articles_that_contain_no_articles():
+    txt = "Justice League"
+    expected_result = "Justice League"
     result = utils.remove_articles(txt)
     assert result == expected_result