Add option for version_key #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pineapplehunter
force-pushed
the
master
branch
from
87c08c0 to
ead246a
Compare
pineapplehunter
force-pushed
the
master
branch
from
ead246a to
d75b334
Compare
|
I just leant that the case I was thinking of (in the test case) was using import from derivation. |
Mic92
reviewed
Jan 10, 2024
| @@ -56,6 +58,12 @@ def parse_args(args: list[str]) -> Options: | |||
| help="Regex to extract version with, i.e. 'jq-(.*)'", | |||
| default="(.*)", | |||
| ) | |||
| parser.add_argument( | |||
| "-vk", | |||
| "--version-key", | |||
There was a problem hiding this comment.
I think version-attr fits better with how nix language names things:
Suggested change
| "--version-key", | |
| "--version-attr", |
Mic92
reviewed
Jan 10, 2024
| parser.add_argument( | ||
| "-vk", | ||
| "--version-key", | ||
| help="Key of attribute that holds the version", |
There was a problem hiding this comment.
Suggested change
| help="Key of attribute that holds the version", | |
| help="Name of attribute that holds the version", |
Mic92
reviewed
Jan 10, 2024
| @@ -56,6 +58,12 @@ def parse_args(args: list[str]) -> Options: | |||
| help="Regex to extract version with, i.e. 'jq-(.*)'", | |||
| default="(.*)", | |||
| ) | |||
| parser.add_argument( | |||
| "-vk", | |||
There was a problem hiding this comment.
Not sure we need a short-hand for that:
Suggested change
| "-vk", |
I see this more being used in scripts where the long-form is more descriptive.
|
Yeah. Maybe we can revisit this when we have a better idea how this would be useful... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was having some problems with packaging with different versioning, so I copied this idea from
common-updater-scriptsfrom nixpkgs.Some packages can have a different version from the source repo but could be derived from source. Currently I see no way to update these packages like this with
nix-update.This PR adds an option
version_keyfor this case.By expose a variable that holds the github repo version,
nix-update *name* --version-key *version attr name*could update the package.BTW, I added an option to the argparser so it shows the default values of options on
--help.Thanks!