Try pkg.meta.position after unsafeGetAttrPos #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`meta.position` is prone to point at files where `src` and `version` is not contained, as is the case for overridden packages and packages that use a generic builder.
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 0785ad8 |
|
Fixes the issue for me :) Thanks. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meta.positionis prone to point at files wheresrcandversionis not contained, as is the case for overridden packages and packages that use a generic builder.There is also the fix explored in NixOS/nixpkgs#329900 and NixOS/nixpkgs#295973, which would alleviate many of the errors while creating new ones.
Fixes #247 (comment)