Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating all matching version numbers #296

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Fix updating all matching version numbers #296

merged 1 commit into from
Dec 8, 2024

Conversation

ayyess
Copy link
Contributor

@ayyess ayyess commented Nov 10, 2024

Prior to this change, nix-update would update all version strings which were equal to the specified package to update. Now, only the version line of the specified package will be updated.

@ayyess
Copy link
Contributor Author

ayyess commented Nov 11, 2024

I'll look at fixing the treefmt tests too.

nix_update/update.py Outdated Show resolved Hide resolved
Prior to this change, nix-update would update all version strings which
were equal to the specified package to update. Now, only the version
line of the specified package will be updated. Does not support when
version is let-bound in which case falls back to replacing all.
@Mic92
Copy link
Owner

Mic92 commented Dec 8, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Dec 8, 2024

queue

🛑 The pull request has been merged manually

The pull request has been merged manually at 6f05a35

@Mic92 Mic92 merged commit 6f05a35 into Mic92:main Dec 8, 2024
4 checks passed
Copy link
Contributor

mergify bot commented Dec 8, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #296 has been dequeued. The pull request has been merged manually. The pull request has been merged manually at 6f05a35.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants