This repository has been archived by the owner on Oct 14, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Runtimes with parameters #354
Open
mattbsox
wants to merge
10
commits into
MicroShed:master
Choose a base branch
from
mattbsox:runtimesWithParameters
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
85f3629
Adding parameters to Maven Liberty runtime
mattbsox 352e412
Adding Liberty runtime to boost-gradle
mattbsox d2bad1e
Creating runtime-liberty project for OL and WLP runtimes and common f…
mattbsox cacb178
Moving LibertyBoosters and LibertyServerConfigGenerator to common run…
mattbsox 1372f12
Adding parameters to TomEE runtime and moving Open Liberty Gradle run…
mattbsox 097fe70
Adding debug logic to TomEE
mattbsox b8abeb8
Moving booster tests, creating a common Liberty runtime, adding wlp r…
mattbsox 0022ed0
Moving OpenLiberty Gradle runtime back to boost-gradle
mattbsox b1fd41a
Fixing TomEE debug goal, removing old/duplicate files, and updating c…
mattbsox c14eb02
Fixing artifact versions
mattbsox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ plugins { | |
} | ||
|
||
archivesBaseName = 'boost-gradle-plugin' | ||
group = 'io.openliberty.boost' | ||
group = 'boost' | ||
version = '0.1.1-SNAPSHOT' | ||
|
||
def boosterVersion = '0.1.3-SNAPSHOT' | ||
|
@@ -24,9 +24,9 @@ repositories { | |
|
||
dependencies { | ||
compile localGroovy() | ||
compile 'net.wasdev.wlp.gradle.plugins:liberty-gradle-plugin:2.6.6-SNAPSHOT' | ||
compile 'net.wasdev.wlp.gradle.plugins:liberty-gradle-plugin:2.6.7-SNAPSHOT' | ||
compile group: 'commons-io', name: 'commons-io', version: '2.6' | ||
compile 'io.openliberty.boost:boost-common:0.1.3-SNAPSHOT' | ||
compile 'boost:boost-common:0.1.3-SNAPSHOT' | ||
compile 'com.spotify:docker-client:8.11.7' | ||
|
||
testCompile 'junit:junit:4.12' | ||
|
@@ -39,36 +39,28 @@ test { | |
doFirst { //Copying gradle.properties with plugin version to test projects | ||
String runtimeGroup | ||
String runtimeArtifactId | ||
String libertyRuntime = System.getProperty('runtime') | ||
String runtimeVersion = System.getProperty('runtimeVersion') | ||
String runtime = System.getProperty('runtime') | ||
|
||
if (libertyRuntime == null || libertyRuntime.isEmpty()) { | ||
if (runtime == null || runtime.isEmpty()) { | ||
throw new GradleException('Tests could not be run. Please specify a Liberty runtime. Choose either wlp or ol.') | ||
} | ||
if (runtimeVersion == null || runtimeVersion.isEmpty()) { | ||
throw new GradleException('Tests could not be run. Please specify a Liberty runtime version.') | ||
} | ||
|
||
Properties prop = new Properties() | ||
OutputStream output = null | ||
|
||
try { | ||
output = new FileOutputStream("${buildDir}/gradle.properties") | ||
|
||
if (libertyRuntime == "ol") { | ||
runtimeGroup = "io.openliberty" | ||
runtimeArtifactId = "openliberty-runtime" | ||
} else { | ||
runtimeGroup = "com.ibm.websphere.appserver.runtime" | ||
runtimeArtifactId = "wlp-javaee7" | ||
if (runtime == "ol") { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How do other runtimes get handled? Not understanding why we do something for "ol" specifically here. |
||
runtimeGroup = "boost.runtimes" | ||
runtimeArtifactId = "openliberty-gradle" | ||
} | ||
|
||
// set the properties value | ||
prop.setProperty("boostVersion", version) | ||
prop.setProperty("boosterVersion", boosterVersion) | ||
prop.setProperty("runtimeGroup", runtimeGroup) | ||
prop.setProperty("runtimeArtifactId", runtimeArtifactId) | ||
prop.setProperty("runtimeVersion", runtimeVersion) | ||
|
||
// save properties to project root folder | ||
prop.store(output, null) | ||
|
@@ -165,8 +157,8 @@ if (project.hasProperty('ossrhUsername') && project.hasProperty('ossrhPassword') | |
gradlePlugin { | ||
plugins { | ||
boostPlugin { | ||
id = 'io.openliberty.boost' | ||
implementationClass = 'io.openliberty.boost.gradle.Boost' | ||
id = 'boost' | ||
implementationClass = 'boost.gradle.Boost' | ||
} | ||
} | ||
} |
Binary file not shown.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
apply plugin: 'java' | ||
apply plugin: 'maven' | ||
|
||
repositories { | ||
mavenLocal() | ||
mavenCentral() | ||
} | ||
|
||
dependencies { | ||
compile "boost:boost-common:0.1.3-SNAPSHOT" | ||
compile "boost.runtimes:liberty-common:0.1-SNAPSHOT" | ||
compile "boost:boost-gradle-plugin:0.1.1-SNAPSHOT" | ||
compile 'net.wasdev.wlp.gradle.plugins:liberty-gradle-plugin:2.6.6-SNAPSHOT' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I noticed we used 2.6.7-SNAPSHOT above. |
||
compile "commons-io:commons-io:2.6" | ||
compile localGroovy() | ||
compile gradleApi() | ||
} | ||
|
||
group = 'boost.runtimes' | ||
archivesBaseName = 'openliberty-gradle' | ||
version = '0.1.3-SNAPSHOT' | ||
|
||
jar { | ||
from ('./src/main/resources') { | ||
include 'META-INF/services/boost.common.runtimes.GradleRuntimeI' | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exception explicitly states they need to specify a Liberty runtime. Should it be more generic? Same for the runtimeVersion check below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yup, I'll change these to be boost specific.