Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update article "Win32 sample app" #3242

Merged
merged 23 commits into from
Jan 29, 2025
Merged

Update article "Win32 sample app" #3242

merged 23 commits into from
Jan 29, 2025

Conversation

mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented Aug 1, 2024 •
edited
Loading

Related PR in Samples repo to update screenshot in Readme: MicrosoftEdge/WebView2Samples#262

Rendered article for review:

AB#52989036

@mikehoffms mikehoffms added the cat: webview2 WebView-related content. label Aug 2, 2024
@mikehoffms mikehoffms changed the title VS 2022 fully supported for WebView2 Focus on VS 2022 in article "Debug WebView2 apps with Visual Studio" Aug 5, 2024
@mikehoffms mikehoffms changed the title Focus on VS 2022 in article "Debug WebView2 apps with Visual Studio" Focus on VS 2022 in article "Win32 sample app" Aug 5, 2024
@mikehoffms mikehoffms removed the request for review from victorhuangwq August 5, 2024 20:19
@mikehoffms mikehoffms changed the title Focus on VS 2022 in article "Win32 sample app" Update article "Win32 sample app" Jan 21, 2025
@mikehoffms mikehoffms marked this pull request as ready for review January 21, 2025 01:43
@mikehoffms mikehoffms mentioned this pull request Jan 21, 2025
Merged
mikehoffms
mikehoffms commented Jan 22, 2025
View reviewed changes
Copy link
Collaborator Author

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Content Developer

soumamazu
soumamazu approved these changes Jan 24, 2025
View reviewed changes
Copy link

@soumamazu soumamazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Dev

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit cc019d0:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/get-started/win32.md ✅Succeeded View
microsoft-edge/webview2/how-to/machine-setup.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/all-projects-in-solution-explorer.png ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/open-recent.png ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/review-project-solution-changes.png ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/sample-app-layout-diagram.png ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/visual-studio-installer.png ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/webview2apisample-app-window.png ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/webview2apisample-in-solution-explorer.png ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/webview2apisample-pkg-mgr-prerelease-webview2.png ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/webview2apisample-project-selected.png ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample-images/webview2apisample-unable-to-start-program-cannot-find-path.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/webview2/samples/webview2apissample-images/webview2apisample-webview2-pkg-preview-changes.png ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit 1bc3f54 into main Jan 29, 2025
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/vs2022 branch January 29, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumamazu soumamazu soumamazu approved these changes

@captainbrosset captainbrosset captainbrosset approved these changes

Assignees
No one assigned
Labels
cat: webview2 WebView-related content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikehoffms @captainbrosset @soumamazu