Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move platform info from GetStart tut to general platform page #3340

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Move platform info from GetStart tut to general platform page #3340

wants to merge 20 commits into from

Conversation

mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented Jan 9, 2025 •
edited
Loading

Jan RelNotes promotion to Stable in Release:
Show WPF elements on top of the WebView2 layer (WebView2CompositionControl)
https://learn.microsoft.com/microsoft-edge/webview2/release-notes/?tabs=dotnetcsharp#show-wpf-elements-on-top-of-the-webview2-layer-webview2compositioncontrol
This PR was created to copy that section not into "Overview of APIs", but instead into the planned article WebView2 in WPF apps that's a general platform article for wv2 on WPF.

Rendered articles for review:

RelNotes

Platforms and samples (toc bucket)

AB#55761305

@mikehoffms mikehoffms added cat: webview2 WebView-related content. in-progress labels Jan 9, 2025
@mikehoffms
Copy link
Collaborator Author

mikehoffms commented Jan 20, 2025 •
edited
Loading

https://learn.microsoft.com/en-us/microsoft-edge/webview2/release-notes/?tabs=dotnetcsharp#102957106 --
No additional APIs have been promoted to Stable and added in this Release SDK.

update: in the PR for Prerelease, added a Release section/tabset.

@mikehoffms mikehoffms closed this Jan 20, 2025
@mikehoffms mikehoffms reopened this Jan 24, 2025
@mikehoffms mikehoffms marked this pull request as ready for review January 24, 2025 19:20
@mikehoffms mikehoffms changed the title Update "Overview of APIs" for January 2025 Move platform info from GetStart tut to general platform page Jan 27, 2025
mikehoffms
mikehoffms commented Jan 27, 2025
View reviewed changes
microsoft-edge/webview2/platforms/winui2-uwp.md
* .NET: [WebView2.DefaultBackgroundColor Property](/dotnet/api/microsoft.web.webview2.winforms.webview2.defaultbackgroundcolor)
* Win32: [ICoreWebView2Controller2::DefaultBackgroundColor property (get](/microsoft-edge/webview2/reference/win32/icorewebview2controller2#get_defaultbackgroundcolor), [put)](/microsoft-edge/webview2/reference/win32/icorewebview2controller2#put_defaultbackgroundcolor)
<!-- todo: relevant?
* WinRT: [CoreWebView2Controller.DefaultBackgroundColor Property](https://learn.microsoft.com/microsoft-edge/webview2/reference/winrt/microsoft_web_webview2_core/corewebview2controller#defaultbackgroundcolor)
Copy link
Collaborator Author

@mikehoffms mikehoffms Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is WinRT API Ref relevant; add this link? Only .NET & Win32 are listed.
Does the live article
https://learn.microsoft.com/microsoft-edge/webview2/get-started/winui2#setting-defaultbackgroundcolor
apply to WinRT? Article has 0 hits on "winrt".

WinRT: CoreWebView2Controller.DefaultBackgroundColor Property:
https://learn.microsoft.com/microsoft-edge/webview2/reference/winrt/microsoft_web_webview2_core/corewebview2controller#defaultbackgroundcolor

mikehoffms
mikehoffms commented Jan 27, 2025
View reviewed changes
microsoft-edge/webview2/platforms/winui2-uwp.md
-->
<!--
todo: relevant?
* .NET: [CoreWebView2Controller.DefaultBackgroundColor Property](https://learn.microsoft.com/dotnet/api/microsoft.web.webview2.core.corewebview2controller.defaultbackgroundcolor#microsoft-web-webview2-core-corewebview2controller-defaultbackgroundcolor)
Copy link
Collaborator Author

@mikehoffms mikehoffms Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this other .NET type member relevant, to add?
The article lists .NET WebView2.DefaultBackgroundColor,
but there's also .NET CoreWebView2Controller.DefaultBackgroundColor , add it?

.NET: CoreWebView2Controller.DefaultBackgroundColor Property
https://learn.microsoft.com/dotnet/api/microsoft.web.webview2.core.corewebview2controller.defaultbackgroundcolor#microsoft-web-webview2-core-corewebview2controller-defaultbackgroundcolor

the live article section that has a different .NET type member link (WebView2.DefaultBackgroundColor Property):
https://learn.microsoft.com/microsoft-edge/webview2/get-started/winui2#setting-defaultbackgroundcolor

captainbrosset
captainbrosset reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let others approve first, but from a TOC perspective, this LGTM. I like how this makes the sample articles more focused on samples only, and promotes hard to reach h2 sections into new platform-specific articles.

sivMSFT
sivMSFT requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@sivMSFT sivMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest putting Get Started above sample articles for all the platforms

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 6994c69:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/toc.yml ✅Succeeded View
microsoft-edge/webview2/concepts/overview-features-apis.md ✅Succeeded View
microsoft-edge/webview2/get-started/get-started.md ✅Succeeded View
microsoft-edge/webview2/get-started/hololens2.md ✅Succeeded View
microsoft-edge/webview2/get-started/win32.md ✅Succeeded View
microsoft-edge/webview2/get-started/winforms.md ✅Succeeded View
microsoft-edge/webview2/get-started/winui.md ✅Succeeded View
microsoft-edge/webview2/get-started/winui2.md ✅Succeeded View
microsoft-edge/webview2/get-started/wpf.md ✅Succeeded View
microsoft-edge/webview2/index.md ✅Succeeded View
microsoft-edge/webview2/platforms/hololens-2-unity.md ✅Succeeded View
microsoft-edge/webview2/platforms/win32.md ✅Succeeded View
microsoft-edge/webview2/platforms/winforms.md ✅Succeeded View
microsoft-edge/webview2/platforms/winui2-uwp.md ✅Succeeded View
microsoft-edge/webview2/platforms/winui3-windows-app-sdk.md ✅Succeeded View
microsoft-edge/webview2/platforms/wpf.md ✅Succeeded View
microsoft-edge/webview2/release-notes/index.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2-winui3-sample.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@mikehoffms mikehoffms requested a review from sivMSFT January 30, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@champnic champnic Awaiting requested review from champnic

@captainbrosset captainbrosset Awaiting requested review from captainbrosset

@sivMSFT sivMSFT Awaiting requested review from sivMSFT

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cat: webview2 WebView-related content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikehoffms @captainbrosset @champnic @sivMSFT