Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use-the-system-health-session.md #9874

Open
wants to merge 2 commits into
base: live
Choose a base branch
from

Conversation

sqlworldwide
Copy link
Contributor

The system_health Extended Events session keeps ten files with a maximum size of 100 MB. You can confirm this by looking at GUI properties or scripting the definition.

ADD TARGET package0.event_file(SET filename=N'system_health.xel',max_file_size=(100),max_rollover_files=(10)),

The system_health Extended Events session keeps ten files with a maximum size of 100 MB. You can confirm this by looking at GUI properties or scripting the definition.

ADD TARGET package0.event_file(SET filename=N'system_health.xel',max_file_size=(100),max_rollover_files=(10)),
Copy link
Contributor

@sqlworldwide : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 8a2e7cc:

✅ Validation status: passed

File Status Preview URL Details
docs/relational-databases/extended-events/use-the-system-health-session.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Sep 5, 2024

@WilliamDAssafMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Sep 5, 2024
Hi @sqlworldwide - after reviewing the source code, this is a little more complicated. I'm going to update the PR like this, then wait for some engineering confirmation.
Copy link
Contributor

Learn Build status updates of commit 689da68:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/connect/ado-net/sql/azure-active-directory-authentication.md ⚠️Warning Details
docs/relational-databases/extended-events/use-the-system-health-session.md ✅Succeeded

docs/connect/ado-net/sql/azure-active-directory-authentication.md

  • Line 330, Column 1: [Warning: codesnippet-not-found] Invalid code snippet link: '~/../sqlclient/doc/samples/AADAuthenticationCustomDeviceFlowCallback.cs'.
  • Line 338, Column 1: [Warning: codesnippet-not-found] Invalid code snippet link: '~/../sqlclient/doc/samples/ApplicationClientIdAzureAuthenticationProvider.cs'.
  • Line 368, Column 1: [Warning: codesnippet-not-found] Invalid code snippet link: '~/../sqlclient/doc/samples/CustomDeviceCodeFlowAzureAuthenticationProvider.cs'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@rwestMSFT
Copy link
Contributor

@sqlworldwide Does it make sense to add this line, or just replace the currently noted limits? I'm not familiar with this subject matter.

@WilliamDAssafMSFT

@WilliamDAssafMSFT
Copy link
Contributor

WilliamDAssafMSFT commented Sep 5, 2024

@sqlworldwide @rwestMSFT after reviewing the source code, this is a little more complicated. It is edition dependent. I updated the PR accordingly, then I'll wait for some engineering confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants