Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add banner about WV2 support to Update README.md #261

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Add banner about WV2 support to Update README.md #261

merged 3 commits into from
Nov 25, 2024

Conversation

lolambean
Copy link
Contributor

Add banner about WV2 support

@lolambean
Update README.md
272281c 
Add banner about WV2 support
@lolambean
Copy link
Contributor Author

#sign-off

Please review and merge this change.

@champnic
Copy link
Member

Hey @lolambean thanks for the contribution. Are you with the Hololens team?

@champnic
Copy link
Member

@lolambean I saw you were making edits to other Microsoft Docs - we probably need a similar change here: https://learn.microsoft.com/en-us/microsoft-edge/webview2/get-started/hololens2

Is that something you want to do, or should our team add similar verbage?

@lolambean
Copy link
Contributor Author

@champnic , yes I am with the HoloLens team. Thanks!

@champnic champnic self-requested a review November 22, 2024 23:34
@lolambean
Copy link
Contributor Author

@champnic, yes, if you want to make that change on this page, that would be great! You'd have to approve it anyway, so feel free to use the same verbiage, as we are using that on all similar pages. Thank you!

lolambean
lolambean commented Nov 23, 2024
View reviewed changes
Copy link
Contributor Author

@lolambean lolambean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added "on HoloLens".

@lolambean lolambean requested a review from champnic November 25, 2024 19:19
@champnic champnic merged commit 96ef509 into MicrosoftEdge:main Nov 25, 2024
2 checks passed
@champnic
Copy link
Member

@lolambean Merged - thanks again for the change! I've got the follow-up change to our other docs here:
MicrosoftDocs/edge-developer#3317

@mikehoffms
Copy link
Contributor

mikehoffms commented Nov 25, 2024 •
edited
Loading

snapshot of draft PR 3317 - cleaned up wording but exactly same content as present PR:
image

Readme of present repo sample:
image

@lolambean lolambean deleted the patch-1 branch November 25, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@champnic champnic champnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lolambean @champnic @mikehoffms