Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#377 [feat] 대댓글 count 반영 #379

Merged
merged 1 commit into from
Jun 6, 2024
Merged

#377 [feat] 대댓글 count 반영 #379

merged 1 commit into from
Jun 6, 2024

Conversation

sohyundoh
Copy link
Member

@sohyundoh sohyundoh commented Jun 5, 2024 •
edited
Loading

✒️ 관련 이슈번호

Key Changes 🔑

  1. 대댓글 숫자가 반영이 안되고 있었음을 깨닫고 반영하는 로직을 구현했습니다!
  2. iterator를 통해 comment별로 reply의 개수를 더해주었습니다!
  3. 로직이 비정규화를 반영하면 어떨까라는 생각이 드네요..!

To Reviewers 📢

@sohyundoh sohyundoh self-assigned this Jun 5, 2024
parkheeddong
parkheeddong approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@parkheeddong parkheeddong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업하느라 고생하셨습니다 :> LGTM! 말씀하신 대로 리팩토링 때 비정규화 진행해보면 좋을 것 같네용 API 위치 상 조회가 많을 것 같은데.. 매번 계산하기보다는 비정규화 해서 댓글 추가될 때마다 카운트 증가시키면 성능 이점이 클 것 같습니다

@sohyundoh sohyundoh merged commit d86f325 into develop Jun 6, 2024
1 check passed
@sohyundoh sohyundoh deleted the feat/#377 branch June 6, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkheeddong parkheeddong parkheeddong approved these changes

Assignees

@sohyundoh sohyundoh

Labels
highest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 게시글 총 댓글 개수에 대댓글 개수 포함
2 participants
@sohyundoh @parkheeddong