#381 [feat] 관리자 페이지 멤버관련 수정 #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkheeddong
approved these changes
Jun 10, 2024
|
|
||
| public int findCommentCountByWriterNameId( | ||
| final Long writerNameId | ||
| ) { | ||
| return commentRepository.countByWriterNameId(writerNameId); | ||
| return commentRepository.countByWriterNameId(writerNameId) + commentReplyRetriever.countByWriterNameId(writerNameId); |
There was a problem hiding this comment.
P5) 단순 궁금증인데 서비스명을 commentReplyRetreiver로 명명하신 이유가 있나유?
There was a problem hiding this comment.
Component로 빈 등록을 했기 때문에 Service라는 명을 사용하지 않고자 했는데요! 그렇다고 Getter를 하기엔 기존에 getter 함수와 이름이 충돌했습니다! 그래서 찾는다는 의미에 Retriever로 명명했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
Key Changes 🔑
To Reviewers 📢