#385 [feat] 글모임 삭제 API 구현 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohyundoh
requested changes
Jun 13, 2024
Comment on lines
21
to
24
| @Service | ||
| @Slf4j | ||
| @RequiredArgsConstructor | ||
| public class MoimDeleteService { |
There was a problem hiding this comment.
P1
DeleteService는 Controller에서 참조하면 안됩니다!
DeleteService와 같은 세부 역할은 MoimService를 타고 들어와야 합니다.
또한 기존에 말했던 Helper계층과 관련해서 MoimRemover로 클래스명을 변경한 뒤 빈 설정을 @Service가 아닌 @Component로 해주는 것이 어떨까요?
There was a problem hiding this comment.
좋습니다! 제가 착각을 하고 있었네요..ㅠ-ㅠ 감사합니다 :D
Comment on lines
35
to
36
|
|
||
| void deleteAllByMoim(final Moim moim); |
There was a problem hiding this comment.
P3
성능을 위해 Jpql의 벌크 delete를 사용해도 좋을 것 같아요! 한 번 공부해보는 걸 추천 드립니다!
sohyundoh
requested changes
Jun 14, 2024
| @@ -49,7 +49,6 @@ public void deleteMoim( | |||
| curiousService.deleteAllByPosts(posts); | |||
| postDeleteService.deletePosts(posts); | |||
| topicService.deleteTopics(topics); | |||
| writerNameDeleteService.deleteWriterNamesByMoim(moim); | |||
There was a problem hiding this comment.
P2
혹시 이걸 지운 이유가 있을까요?
위에 Cascade 설정은 owner에만 걸려있어서 실제 owner가 아닌 writerName들에는 적용이 안될 것 같습니다!
| @@ -49,7 +49,6 @@ public void deleteMoim( | |||
| curiousService.deleteAllByPosts(posts); | |||
| postDeleteService.deletePosts(posts); | |||
| topicService.deleteTopics(topics); | |||
There was a problem hiding this comment.
P3
서비스들을 명명하거나 delete 메서드인데도 그냥 service를 보는 경우, deleteService를 보는 경우를 Remover로 정리해주어도 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
Key Changes 🔑
글모임 삭제 API 구현하였습니다!
To Reviewers 📢
글모임 삭제는
로 진행됩니다!