#386 [feat] 필명, 글모임명 중복체크 중 띄어쓰기 관련 로직 구현 #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohyundoh
requested changes
Jun 13, 2024
|
|
||
| boolean existsWriterNameByMoimAndName(final Moim moim, final String name); | ||
| @Query("SELECT CASE WHEN COUNT(w) > 0 THEN TRUE ELSE FALSE END FROM WriterName w WHERE w.moim = :moim AND w.normalizedName = :normalizedName") | ||
| boolean existsWriterNameByMoimAndName(@Param("moim") Moim moim, @Param("normalizedName") String normalizedName); |
| @@ -18,8 +20,8 @@ public interface WriterNameRepository extends JpaRepository<WriterName, Long> { | |||
|
|
|||
| List<WriterName> findByMoimId(final Long moimId); | |||
|
|
|||
|
|
|||
| boolean existsWriterNameByMoimAndName(final Moim moim, final String name); | |||
| @Query("SELECT CASE WHEN COUNT(w) > 0 THEN TRUE ELSE FALSE END FROM WriterName w WHERE w.moim = :moim AND w.normalizedName = :normalizedName") | |||
There was a problem hiding this comment.
P3
기존 쿼리를 사용하지 않은 대신 JPQL을 사용한 이유가 있으신가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
Key Changes 🔑
글모임과 필명 모두 "normalizedName"로 띄어쓰기를 제거하고, 대소문자를 소문자로 변경한 필드를 두었습니다.
글모임명, 필명 생성 과정에서 normalizedName 값을 저장하도록 하였고,
(현재 수정 로직이 있는 경우에 대해서는) normalizedName 값도 수정되도록 하였습니다.
현재 로직에서는 이렇게 normalizedName이 name과 함께 생성 및 변동될 수 있도록 하였지만
데이터 무결성을 확실히 지킬 수 있는 방법을 찾아보았고 prepersist, preupdate 어노테이션을 적용해보았습니다.
엔티티가 db에 저장되기 전, 그리고 엔티티의 상태가 변경되어 데이터베이스에 업데이트되기 전에 호출되는 어노테이션입니다.