#447 [feat] 글 상세 뷰 에러 코드 세분화 #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkheeddong
approved these changes
Aug 5, 2024
| MOIM_OWNER_AUTHENTICATION_ERROR(HttpStatus.FORBIDDEN.value(), "사용자는 해당 모임의 모임장이 아닙니다."), | ||
| WRITER_NAME_INFO_FORBIDDEN(HttpStatus.FORBIDDEN.value(), "해당 사용자는 필명에 접근 권한이 없습니다."), | ||
| COMMENT_ACCESS_ERROR(HttpStatus.FORBIDDEN.value(), "해당 사용자는 댓글에 접근 권한이 없습니다."), | ||
| COMMENT_ACCESS_ERROR(40306, "해당 사용자는 댓글에 접근 권한이 없습니다."), |
There was a problem hiding this comment.
P5) 사소하지만.. 40305 인것 같숩니다!
| writerNameRetriever.findWriterNameByMoimIdAndUserId(moimId, userId)); | ||
| Long moimId = post.getTopic().getMoim().getId(); | ||
| WriterName writerName = writerNameRetriever.findByMoimAndUser(moimId, userId); | ||
| if(!postRetriever.isWriterOfPost(post, writerName) && !moimRetriever.isMoimOwnerEqualsUser(post.getTopic().getMoim(), userId)){ |
There was a problem hiding this comment.
P5) and 가 아니라 or 이 들어가야 하는 조건문 아닌가요?!
There was a problem hiding this comment.
모임장을 체크하는 조건, 글쓴이를 체크하는 조건 이 두 조건이 모두 false이면 예외인 점이어서 ! 연산자를 통해 예외를 던지게 했습니다! 제가 잘못 작성한 것 일까요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
Key Changes 🔑
(중요도 상)
(중요도 하)
4. 이전에 반영되어 있지 않던, 댓글 대댓글 길이 관련한 DB 제약사항 변경했습니다.
5. WriterName테이블의 Constraints와 이름 명명이 카멜케이스가 아닌 다른 방법으로 적용되어 있어서 수정했습니다.
To Reviewers 📢