warning: unneeded `return` statement
   --> src/util/game_milestones.rs:19:3
    |
19  | /   return vec![
20  | |     MilestoneCriteria {
21  | |       name: "geyser".to_string(),
22  | |       completed: vec![],
...   |
227 | |     },
228 | |   ];
    | |___^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
19  ~   vec![
20  +     MilestoneCriteria {
21  +       name: "geyser".to_string(),
22  +       completed: vec![],
23  +       introduced: vec![],
24  +     },
25  +     MilestoneCriteria {
26  +       // (village1-yakow 10)
27  +       // (village1-mayor-money 11)
28  +       // (village1-uncle-money 12)
29  +       // (village1-oracle-money1 13)
30  +       // (village1-oracle-money2 14)
31  +       // (beach-ecorocks 15)
32  +       // (village1-buzzer 75)
33  +       name: "sandover".to_string(),
34  +       completed: vec![10, 11, 12, 13, 14, 75],
35  +       introduced: vec![15],
36  +     },
37  +     MilestoneCriteria {
38  +       // (beach-ecorocks 15)
39  +       // (beach-pelican 16)
40  +       // (beach-flutflut 17)
41  +       // (beach-seagull 18)
42  +       // (beach-cannon 19)
43  +       // (beach-buzzer 20)
44  +       // (beach-gimmie 21)
45  +       // (beach-sentinel 22)
46  +       name: "sentinel".to_string(),
47  +       completed: vec![15, 16, 17, 18, 19, 20, 21, 22],
48  +       introduced: vec![],
49  +     },
50  +     MilestoneCriteria {
51  +       // (jungle-eggtop 2)
52  +       // (jungle-lurkerm 3)
53  +       // (jungle-tower 4)
54  +       // (jungle-fishgame 5)
55  +       // (jungle-plant 6)
56  +       // (jungle-buzzer 7)
57  +       // (jungle-canyon-end 8)
58  +       // (jungle-temple-door 9)
59  +       name: "jungle".to_string(),
60  +       completed: vec![2, 3, 4, 5, 6, 7, 8, 9],
61  +       introduced: vec![],
62  +     },
63  +     MilestoneCriteria {
64  +       // (misty-muse 23)
65  +       // (misty-boat 24)
66  +       // (misty-warehouse 25)
67  +       // (misty-cannon 26)
68  +       // (misty-bike 27)
69  +       // (misty-buzzer 28)
70  +       // (misty-bike-jump 29)
71  +       // (misty-eco-challenge 30)
72  +       // (leaving-misty 114)
73  +       name: "misty".to_string(),
74  +       completed: vec![23, 24, 25, 26, 27, 28, 29, 30, 114],
75  +       introduced: vec![],
76  +     },
77  +     MilestoneCriteria {
78  +       // (firecanyon-buzzer 68)
79  +       // (firecanyon-end 69)
80  +       // (firecanyon-assistant 102)
81  +       name: "firecanyon".to_string(),
82  +       completed: vec![68, 69],
83  +       introduced: vec![102],
84  +     },
85  +     MilestoneCriteria {
86  +       // (village2-gambler-money 31)
87  +       // (village2-geologist-money 32)
88  +       // (village2-warrior-money 33)
89  +       // (village2-oracle-money1 34)
90  +       // (village2-oracle-money2 35)
91  +       // (firecanyon-buzzer 68)
92  +       // (firecanyon-end 69)
93  +       // (village2-buzzer 76)
94  +       // (firecanyon-assistant 102)
95  +       name: "village2".to_string(),
96  +       completed: vec![31, 32, 33, 34, 35, 68, 69],
97  +       introduced: vec![76, 102],
98  +     },
99  +     MilestoneCriteria {
100 +       // (rolling-race 52)
101 +       // (rolling-robbers 53)
102 +       // (rolling-moles 54)
103 +       // (rolling-plants 55)
104 +       // (rolling-lake 56)
105 +       // (rolling-buzzer 57)
106 +       // (rolling-ring-chase-1 58)
107 +       // (rolling-ring-chase-2 59)
108 +       name: "basin".to_string(),
109 +       completed: vec![52, 53, 54, 55, 56, 57, 58, 59],
110 +       introduced: vec![],
111 +     },
112 +     MilestoneCriteria {
113 +       // (swamp-billy 36)
114 +       // (swamp-flutflut 37)
115 +       // (swamp-battle 38)
116 +       // (swamp-tether-1 39)
117 +       // (swamp-tether-2 40)
118 +       // (swamp-tether-3 41)
119 +       // (swamp-tether-4 42)
120 +       // (swamp-buzzer 43)
121 +       // (swamp-arm 104)
122 +       name: "swamp".to_string(),
123 +       completed: vec![36, 37, 38, 39, 40, 41, 42, 43, 104],
124 +       introduced: vec![],
125 +     },
126 +     MilestoneCriteria {
127 +       // (sunken-platforms 44)
128 +       // (sunken-pipe 45)
129 +       // (sunken-slide 46)
130 +       // (sunken-room 47)
131 +       // (sunken-sharks 48)
132 +       // (sunken-buzzer 49)
133 +       // (sunken-top-of-helix 50)
134 +       // (sunken-spinning-room 51)
135 +       name: "lpc".to_string(),
136 +       completed: vec![44, 45, 46, 47, 48, 49, 50, 51],
137 +       introduced: vec![],
138 +     },
139 +     MilestoneCriteria {
140 +       // (ogre-boss 86)
141 +       // (village2-levitator 103)
142 +       name: "klaww".to_string(),
143 +       completed: vec![103],
144 +       introduced: vec![86],
145 +     },
146 +     MilestoneCriteria {
147 +       // (ogre-boss 86)
148 +       // (ogre-end 87)
149 +       // (ogre-buzzer 88)
150 +       // (ogre-secret 110)
151 +       name: "mountainpass".to_string(),
152 +       completed: vec![86, 88, 110],
153 +       introduced: vec![87],
154 +     },
155 +     MilestoneCriteria {
156 +       // (village3-extra1 74)
157 +       // (village3-buzzer 77)
158 +       // (village3-miner-money1 96)
159 +       // (village3-miner-money2 97)
160 +       // (village3-miner-money3 98)
161 +       // (village3-miner-money4 99)
162 +       // (village3-oracle-money1 100)
163 +       // (village3-oracle-money2 101)
164 +       // (village3-button 105)
165 +       name: "village3".to_string(),
166 +       completed: vec![74, 77, 96, 97, 98, 99, 100, 101, 105],
167 +       introduced: vec![],
168 +     },
169 +     MilestoneCriteria {
170 +       // (cave-gnawers 78)
171 +       // (cave-dark-crystals 79)
172 +       // (cave-dark-climb 80)
173 +       // (cave-robot-climb 81)
174 +       // (cave-swing-poles 82)
175 +       // (cave-spider-tunnel 83)
176 +       // (cave-platforms 84)
177 +       // (cave-buzzer 85)
178 +       name: "cave".to_string(),
179 +       completed: vec![78, 79, 80, 81, 82, 83, 84, 85],
180 +       introduced: vec![],
181 +     },
182 +     MilestoneCriteria {
183 +       // (snow-eggtop 60)
184 +       // (snow-ram 61)
185 +       // (snow-fort 62)
186 +       // (snow-ball 63)
187 +       // (snow-bunnies 64)
188 +       // (snow-buzzer 65)
189 +       // (snow-bumpers 66)
190 +       // (snow-cage 67)
191 +       name: "snowy".to_string(),
192 +       completed: vec![60, 61, 62, 63, 64, 65, 66, 67],
193 +       introduced: vec![],
194 +     },
195 +     MilestoneCriteria {
196 +       // (lavatube-end 89)
197 +       // (lavatube-buzzer 90)
198 +       // (lavatube-balls 107)
199 +       // (lavatube-start 108)
200 +       // (assistant-village3 115)
201 +       name: "lavatube".to_string(),
202 +       completed: vec![90, 107, 108, 115],
203 +       introduced: vec![89],
204 +     },
205 +     MilestoneCriteria {
206 +       // (citadel-sage-green 70)
207 +       // (citadel-sage-blue 71)
208 +       // (citadel-sage-red 72)
209 +       // (citadel-sage-yellow 73)
210 +       // (lavatube-end 89)
211 +       // (citadel-buzzer 91)
212 +       name: "citadel".to_string(),
213 +       completed: vec![71, 72, 73, 89, 91],
214 +       introduced: vec![70],
215 +     },
216 +     MilestoneCriteria {
217 +       // (citadel-sage-green 70)
218 +       name: "finalboss".to_string(),
219 +       completed: vec![70],
220 +       introduced: vec![],
221 +     },
222 +     MilestoneCriteria {
223 +       // (finalboss-movies 112)
224 +       name: "end".to_string(),
225 +       completed: vec![],
226 +       introduced: vec![112],
227 +     },
228 ~   ]
    |

warning: file opened with `create`, but `truncate` behavior not defined
  --> src/util/file.rs:63:6
   |
63 |     .create(true)
   |      ^^^^^^^^^^^^- help: add: `.truncate(true)`
   |
   = help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
   = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
   = help: alternatively, use `.append(true)` to append to the file instead of overwriting it
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
   = note: `#[warn(clippy::suspicious_open_options)]` on by default

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> src/config.rs:653:10
    |
653 |       if (mod_source_index as usize) < sources.len() {
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `mod_source_index`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/config.rs:626:58
    |
626 |     let game_config = self.get_supported_game_config_mut(&game_name)?;
    |                                                          ^^^^^^^^^^ help: change this to: `game_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: unneeded `return` statement
   --> src/config.rs:274:9
    |
274 | /         return Err(ConfigError::Configuration(format!(
275 | |           "Supported game missing from games map: {game_name}"
276 | |         )));
    | |___________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
274 ~         Err(ConfigError::Configuration(format!(
275 +           "Supported game missing from games map: {game_name}"
276 ~         )))
    |

warning: unneeded `return` statement
   --> src/config.rs:253:9
    |
253 | /         return Err(ConfigError::Configuration(format!(
254 | |           "Supported game missing from games map: {game_name}"
255 | |         )));
    | |___________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
253 ~         Err(ConfigError::Configuration(format!(
254 +           "Supported game missing from games map: {game_name}"
255 ~         )))
    |

warning: the borrowed expression implements the required traits
   --> src/commands/support.rs:160:44
    |
160 |     let data_dir = active_version_dir.join(&game_name).join("data");
    |                                            ^^^^^^^^^^ help: change this to: `game_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> src/commands/support.rs:148:11
    |
148 |     .join(&game_name)
    |           ^^^^^^^^^^ help: change this to: `game_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> src/commands/support.rs:145:11
    |
145 |     .join(&game_name)
    |           ^^^^^^^^^^ help: change this to: `game_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> src/commands/support.rs:139:11
    |
139 |     .join(&game_name)
    |           ^^^^^^^^^^ help: change this to: `game_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> src/commands/support.rs:129:46
    |
129 |   let jak1_log_dir = active_version_dir.join(&game_name).join("data").join("log");
    |                                              ^^^^^^^^^^ help: change this to: `game_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> src/commands/support.rs:119:27
    |
119 |     &game_config_dir.join(&game_name).join("saves"),
    |                           ^^^^^^^^^^ help: change this to: `game_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> src/commands/support.rs:110:27
    |
110 |     &game_config_dir.join(&game_name).join("misc"),
    |                           ^^^^^^^^^^ help: change this to: `game_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> src/commands/support.rs:101:27
    |
101 |     &game_config_dir.join(&game_name).join("settings"),
    |                           ^^^^^^^^^^ help: change this to: `game_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
   --> src/commands/game.rs:192:9
    |
192 | /         match get_saves_highest_milestone(&entry.into_path(), &milestones) {
193 | |           Some((name, idx)) => {
194 | |             info!("Furthest milestone {} at index {}", name, idx);
195 | |             if idx > highest_milestone_idx {
...   |
200 | |           None => {}
201 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
    = note: `#[warn(clippy::single_match)]` on by default
help: try
    |
192 ~         if let Some((name, idx)) = get_saves_highest_milestone(&entry.into_path(), &milestones) {
193 +           info!("Furthest milestone {} at index {}", name, idx);
194 +           if idx > highest_milestone_idx {
195 +             highest_milestone_idx = idx;
196 +             furthest_milestone_name = name.to_owned();
197 +           }
198 +         }
    |

warning: the borrowed expression implements the required traits
   --> src/commands/game.rs:185:29
    |
185 |   for entry in WalkDir::new(&game_save_dir)
    |                             ^^^^^^^^^^^^^^ help: change this to: `game_save_dir`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: unneeded `return` statement
   --> src/commands/game.rs:206:3
    |
206 |   return Ok(furthest_milestone_name);
    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
206 -   return Ok(furthest_milestone_name);
206 +   Ok(furthest_milestone_name)
    |

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/commands/game.rs:128:48
    |
128 |       if tasks.contains_key(&task_id) && tasks[&task_id].completed {
    |                                                ^^^^^^^^ help: change this to: `task_id`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/commands/game.rs:128:29
    |
128 |       if tasks.contains_key(&task_id) && tasks[&task_id].completed {
    |                             ^^^^^^^^ help: change this to: `task_id`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/commands/game.rs:123:48
    |
123 |       if tasks.contains_key(&task_id) && tasks[&task_id].introduced {
    |                                                ^^^^^^^^ help: change this to: `task_id`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/commands/game.rs:123:29
    |
123 |       if tasks.contains_key(&task_id) && tasks[&task_id].introduced {
    |                             ^^^^^^^^ help: change this to: `task_id`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
  --> src/commands/game.rs:82:15
   |
82 |   milestones: &Vec<MilestoneCriteria>,
   |               ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[MilestoneCriteria]`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
   = note: `#[warn(clippy::ptr_arg)]` on by default

warning: unneeded `return` statement
   --> src/commands/game.rs:134:3
    |
134 |   return None;
    |   ^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
134 -   return None;
134 +   None
    |

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/commands/features.rs:428:35
    |
428 |   extract_zip_file(&zip_path_buf, &destination_dir, false).map_err(|err| {
    |                                   ^^^^^^^^^^^^^^^^ help: change this to: `destination_dir`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits
   --> src/commands/features.rs:422:11
    |
422 |     .join(&mod_name);
    |           ^^^^^^^^^ help: change this to: `mod_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args