Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change URL of minio service #86

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Change URL of minio service #86

merged 1 commit into from
Dec 16, 2024

Conversation

laurensWe
Copy link
Member

Description

Describe in detail the changes you are proposing, and the rationale.

Link all GitHub issues fixed by this PR.
Make sure to first open an issue, get community approval and only then create Pull Request to resolve it.
All Pull Requests must have an issue attached to them

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@laurensWe laurensWe requested a review from a team as a code owner December 13, 2024 13:56
Copy link
Contributor

MANIFESTDIFF


diff -burN ./main-manifests/apps/amt/overlays/production/manifests.yaml ./pr-manifests/apps/amt/overlays/production/manifests.yaml
--- ./main-manifests/apps/amt/overlays/production/manifests.yaml	2024-12-13 13:57:02.703505627 +0000
+++ ./pr-manifests/apps/amt/overlays/production/manifests.yaml	2024-12-13 13:57:01.835518378 +0000
@@ -356,7 +356,7 @@
         - name: ENVIRONMENT
           value: production
         - name: OBJECT_STORE_URL
-          value: amt-svc-minio
+          value: svc-minio
         - name: OBJECT_STORE_BUCKET_NAME
           value: amt
         - name: OBJECT_STORE_PASSWORD
diff -burN ./main-manifests/apps/amt/overlays/sandbox/manifests.yaml ./pr-manifests/apps/amt/overlays/sandbox/manifests.yaml
--- ./main-manifests/apps/amt/overlays/sandbox/manifests.yaml	2024-12-13 13:57:02.767504687 +0000
+++ ./pr-manifests/apps/amt/overlays/sandbox/manifests.yaml	2024-12-13 13:57:01.895517497 +0000
@@ -356,7 +356,7 @@
         - name: ENVIRONMENT
           value: production
         - name: OBJECT_STORE_URL
-          value: amt-svc-minio
+          value: svc-minio
         - name: OBJECT_STORE_BUCKET_NAME
           value: amt
         - name: OBJECT_STORE_PASSWORD

@laurensWe laurensWe merged commit e8f407b into main Dec 16, 2024
8 checks passed
@laurensWe laurensWe deleted the bugfix/service_name_minio branch December 16, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants