Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TAD references to AMT #174

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Rename TAD references to AMT #174

merged 2 commits into from
Jul 23, 2024

Conversation

laurensWe
Copy link
Member

@laurensWe laurensWe commented Jul 9, 2024

Description

Rename all TAD references to AMT and also textual explanations
TODO: one link is broken as github.com/minbzk/amt does not exist yet

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin below, which this project utilizes.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@laurensWe laurensWe requested a review from a team as a code owner July 9, 2024 13:14
@laurensWe laurensWe linked an issue Jul 9, 2024 that may be closed by this pull request
berrydenhartog
berrydenhartog previously approved these changes Jul 13, 2024
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurensWe laurensWe requested a review from berrydenhartog July 23, 2024 11:25
@laurensWe
Copy link
Member Author

This can now be merged as the repository of amt has changed

@laurensWe laurensWe requested a review from ravimeijerrig July 23, 2024 11:54
Copy link
Contributor

@ravimeijerrig ravimeijerrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@laurensWe laurensWe merged commit 327eaf6 into main Jul 23, 2024
4 checks passed
@laurensWe laurensWe deleted the 84-rename-tad-to-amt branch July 23, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename TAD to AMT
3 participants