Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add adr for GUI implementation #199

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Add adr for GUI implementation #199

merged 1 commit into from
Sep 19, 2024

Conversation

rubenrouwhof
Copy link
Contributor

@rubenrouwhof rubenrouwhof commented Sep 5, 2024 •
edited
Loading

Description

ADR for GUI implementation about NL Design System

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin below, which this project utilizes.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@rubenrouwhof rubenrouwhof requested a review from a team as a code owner September 5, 2024 08:52
@rubenrouwhof rubenrouwhof linked an issue Sep 5, 2024 that may be closed by this pull request
Create ADR for GUI implementation MinBZK/amt#156
Closed
laurensWe
laurensWe reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small remarks

mkdocs.yml Outdated Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
anneschuth
anneschuth previously approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, lgtm

docs/projects/amt/adrs/0007-front-end-components-implementation.md Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
GuusjeJuijn
GuusjeJuijn reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@GuusjeJuijn GuusjeJuijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM some minor comments!

docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
uittenbroekrobbert
uittenbroekrobbert reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you adhere to the checklist requirements, like squash and tested locally etc, and mark completed where applicable?

ChristopherSpelt
ChristopherSpelt previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
@rubenrouwhof rubenrouwhof force-pushed the add-adr-for-gui branch 2 times, most recently from ea53160 to afa3a85 Compare September 16, 2024 11:53
robbertbos
robbertbos requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@robbertbos robbertbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...but also left some suggestions

mkdocs.yml Outdated Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Show resolved Hide resolved
docs/projects/amt/adrs/0007-front-end-components-implementation.md Outdated Show resolved Hide resolved
@rubenrouwhof rubenrouwhof force-pushed the add-adr-for-gui branch 4 times, most recently from cf7d190 to 67e15f8 Compare September 19, 2024 12:33
robbertbos
robbertbos previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@robbertbos robbertbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. You became a git hero ;) One suggestion, but not a blocker.

mkdocs.yml Outdated Show resolved Hide resolved
@robbertbos robbertbos merged commit 358f287 into main Sep 19, 2024
4 checks passed
@robbertbos robbertbos deleted the add-adr-for-gui branch September 19, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert left review comments

@GuusjeJuijn GuusjeJuijn GuusjeJuijn left review comments

@laurensWe laurensWe laurensWe left review comments

@robbertbos robbertbos robbertbos approved these changes

@ChristopherSpelt ChristopherSpelt ChristopherSpelt left review comments

@anneschuth anneschuth anneschuth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create ADR for GUI implementation
7 participants
@rubenrouwhof @anneschuth @robbertbos @laurensWe @ChristopherSpelt @GuusjeJuijn @uittenbroekrobbert