Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove adding task in algorithm creation #398

Conversation

ChristopherSpelt
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt commented Nov 25, 2024

Description

Removes tasks creation from selected instruments when creating a new algorithm.
The task table in the DB is NOT dropped and task related repositories and services are NOT removed/
After merging this PR we can delete contents of the task table

Resolves #381

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@ChristopherSpelt ChristopherSpelt force-pushed the 381-remove-instrument-related-tasks-that-are-visible-on-the-tab-tasks branch from 8dc230a to ee46cbe Compare November 25, 2024 10:41
@ChristopherSpelt ChristopherSpelt force-pushed the 381-remove-instrument-related-tasks-that-are-visible-on-the-tab-tasks branch from e66b1de to 6dc9e17 Compare November 25, 2024 10:43
Copy link

sonarcloud bot commented Nov 25, 2024

@ChristopherSpelt ChristopherSpelt marked this pull request as ready for review November 25, 2024 10:49
@ChristopherSpelt ChristopherSpelt requested a review from a team as a code owner November 25, 2024 10:49
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ChristopherSpelt ChristopherSpelt merged commit a86c1ef into main Nov 25, 2024
14 checks passed
@ChristopherSpelt ChristopherSpelt deleted the 381-remove-instrument-related-tasks-that-are-visible-on-the-tab-tasks branch November 25, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove instrument related tasks that are visible on the tab Tasks
2 participants