Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update beslisboom to version v1.2.0 #413

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Update beslisboom to version v1.2.0 #413

merged 1 commit into from
Dec 9, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented Dec 4, 2024 •
edited
Loading

Description

Resolves #377

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog linked an issue Dec 4, 2024 that may be closed by this pull request
Bump version of beslishulp in AMT #377
Closed
@berrydenhartog berrydenhartog force-pushed the 377-bump-version-of-beslishulp-in-amt branch 9 times, most recently from 162c544 to 6087546 Compare December 6, 2024 12:37
@berrydenhartog berrydenhartog marked this pull request as ready for review December 6, 2024 12:37
@berrydenhartog berrydenhartog requested a review from a team as a code owner December 6, 2024 12:37
@berrydenhartog berrydenhartog force-pushed the 377-bump-version-of-beslishulp-in-amt branch 2 times, most recently from 9b9edb2 to 2ef176b Compare December 6, 2024 12:44
@berrydenhartog berrydenhartog force-pushed the 377-bump-version-of-beslishulp-in-amt branch from 2ef176b to 20aeb0a Compare December 6, 2024 12:54
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
77.0% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube Cloud

laurensWe
laurensWe approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@berrydenhartog berrydenhartog merged commit 79e63cb into main Dec 9, 2024
14 of 15 checks passed
@berrydenhartog berrydenhartog deleted the 377-bump-version-of-beslishulp-in-amt branch December 9, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurensWe laurensWe laurensWe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump version of beslishulp in AMT
2 participants
@berrydenhartog @laurensWe