Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

374 export algorithm system card as yaml #417

Merged
merged 3 commits into from
Dec 10, 2024
Merged

374 export algorithm system card as yaml #417

merged 3 commits into from
Dec 10, 2024

Conversation

laurensWe
Copy link
Member

@laurensWe laurensWe commented Dec 9, 2024 •
edited
Loading

Description

  • Add endpoint to download system card as a yaml with iso timestamp
  • Add logic to pop-up when download icon is pressed

Resolves #374

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@laurensWe laurensWe requested a review from a team as a code owner December 9, 2024 09:16
@laurensWe laurensWe linked an issue Dec 9, 2024 that may be closed by this pull request
Export Algorithm System Card as YAML #374
Closed
@laurensWe laurensWe force-pushed the 374-export-algorithm-system-card-as-yaml branch from 4b9e612 to dc98894 Compare December 9, 2024 09:21
berrydenhartog
berrydenhartog previously approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurensWe laurensWe force-pushed the 374-export-algorithm-system-card-as-yaml branch from dc98894 to b4b19a5 Compare December 9, 2024 09:37
berrydenhartog
berrydenhartog previously approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurensWe laurensWe enabled auto-merge December 9, 2024 09:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
29.7% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube Cloud

berrydenhartog
berrydenhartog approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurensWe laurensWe merged commit 02fc060 into main Dec 10, 2024
14 of 15 checks passed
@laurensWe laurensWe deleted the 374-export-algorithm-system-card-as-yaml branch December 10, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berrydenhartog berrydenhartog berrydenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export Algorithm System Card as YAML
2 participants
@laurensWe @berrydenhartog