Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure CardPublications #683

Merged
merged 3 commits into from
Nov 28, 2024
Merged

restructure CardPublications #683

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0641499
restructure CardPublications
sgort Nov 27, 2024
6c68b3b
added changeset
sgort Nov 27, 2024
c42173b
refactor: rename publicaties to standaarden
onursagir Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eight-months-march.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"web": minor
---

Restructuring ReSpec to standaarden instead of publications
8 changes: 4 additions & 4 deletions .../src/app/publicaties/card-publication.tsx → ...web/src/app/publicaties/card-standard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ export const Root: React.FC<Props> = ({ variant = 'published', children, method,
const computedUrl = (() => {
if (url) return url;

if (method && 'publication') {
if (method && 'standard') {
const tree = getMethodTree(method);

if (tree && 'publication' in tree) return tree.publication;
if (tree && 'standard' in tree) return tree.standard;
}
})();

Expand Down Expand Up @@ -57,7 +57,7 @@ export const Root: React.FC<Props> = ({ variant = 'published', children, method,
<Card.Footer>
{method && (
<MethodNavigation.Root method={method}>
<MethodNavigation.MethodItems hide="publication" />
<MethodNavigation.MethodItems hide="standard" />
</MethodNavigation.Root>
)}
{variant === 'unavailable' && <Typography>Binnenkort beschikbaar.</Typography>}
Expand All @@ -67,7 +67,7 @@ export const Root: React.FC<Props> = ({ variant = 'published', children, method,
<>
<Card.Collapse>
<MethodNavigation.Root method={method} orientation="vertical">
<MethodNavigation.MethodItems showLabels hide="publication" />
<MethodNavigation.MethodItems showLabels hide="standard" />
</MethodNavigation.Root>
</Card.Collapse>
<Card.CollapseButton />
Expand Down
36 changes: 18 additions & 18 deletions apps/web/src/app/publicaties/page.tsx
View file
Open in desktop
sgort marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -2,60 +2,60 @@ import { defaultMetaData } from '@/common/default-metadata';
import { Container } from '@/components/container';
import { RemotePage } from '@/components/remote-page';
import { Typography } from '@/components/typography';
import * as CardPublication from './card-publication';
import * as CardStandard from './card-standard';
import { ContainerMethod } from '@/components/container-method';

export default function PublicatiesPage() {
sgort marked this conversation as resolved.
Show resolved Hide resolved
return (
<main>
<Container>
<Typography variant="h1">Publicaties</Typography>
<Typography variant="h1">Standaarden</Typography>
<RemotePage page="publicaties" />
</Container>
<ContainerMethod>
<CardPublication.Root title="Wetsanalyse" method="Wetsanalyse_1">
<CardStandard.Root title="Wetsanalyse" method="Wetsanalyse_1">
Specificatie van het <b>juridisch analyseschema</b> (JAS) dat gebruikt wordt bij Wetsanalyse en waarin
verschillende juridische elementen die in wetgeving voorkomen in samenhang gerangschikt zijn.
</CardPublication.Root>
<CardPublication.Root
</CardStandard.Root>
<CardStandard.Root
title="Wetsuitvoering"
variant="work-in-progress"
url="https://minbzk.github.io/wetsuitvoering/"
>
Specificatie van het <b>juridisch referentiemodel</b> (JRM) dat met scenario&apos;s beschrijft hoe een burger
of bedrijf een bepaald stuk wet- en regelgeving ervaart of doorloopt in de wetsuitvoering.
</CardPublication.Root>
<CardPublication.Root title="DCAT" variant="work-in-progress" url="/publicaties/dcat-ap-ronl">
</CardStandard.Root>
<CardStandard.Root title="DCAT" variant="work-in-progress" url="/publicaties/dcat-ap-ronl">
DCAT-AP is een Europese specificatie voor het beschrijven van datasets van de publieke sector, gebaseerd op
W3C&apos;s Data Catalogue Vocabulary (DCAT).
</CardPublication.Root>
<CardPublication.Root title="De Legitimaat" method="De LegitiMaat">
</CardStandard.Root>
<CardStandard.Root title="De Legitimaat" method="De LegitiMaat">
Een werkmethode voor het doen van onderzoek door derden naar het gebruik van algoritmen door een
overheidsorganisatie.
</CardPublication.Root>
<CardPublication.Root
</CardStandard.Root>
<CardStandard.Root
title="Algoritmes Publicatiestandaard"
url="/publicaties/algoritmeregister-publicatiestandaard"
>
Bevat de publicatiestandaard van het Algoritmeregister. Het is bedoeld om overheidsorganisaties te helpen bij
het invullen.
</CardPublication.Root>
<CardPublication.Root
</CardStandard.Root>
<CardStandard.Root
variant="work-in-progress"
title="Levensgebeurtenissen SIVI AFS"
url="/publicaties/levensgebeurtenissen-sivi-afs"
>
Bevat de standaardisatie van levensgebeurtenissen en signalen in de SIVI All Finance Standaard (SIVI AFS)
</CardPublication.Root>
<CardPublication.Root
</CardStandard.Root>
<CardStandard.Root
variant="work-in-progress"
title="WetsTaal Handreiking"
url="https://minbzk.github.io/wetstaal/"
>
De syntax en semantiek van de logisch formele, declaratieve en breed begrijpelijke taal
</CardPublication.Root>
<CardPublication.Root title="Harmonisator" variant="unavailable" />
<CardPublication.Root title="FLINT" variant="unavailable" />
</CardStandard.Root>
<CardStandard.Root title="Harmonisator" variant="unavailable" />
<CardStandard.Root title="FLINT" variant="unavailable" />
</ContainerMethod>
</main>
);
Expand Down
8 changes: 4 additions & 4 deletions apps/web/src/common/methods-tree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ export interface MethodTree {
color: PillProps['variant'];
docs?: string;
demo?: string;
publication?: string;
standard?: string;
}

export const methodsTree = {
'De LegitiMaat': {
color: 'info',
docs: '/docs/methods/LEGITIMAAT',
publication: '/publicaties/legitimaat',
standard: '/publicaties/legitimaat',
sgort marked this conversation as resolved.
Show resolved Hide resolved
},
FLINT: {
color: 'info',
Expand All @@ -21,13 +21,13 @@ export const methodsTree = {
Wetsanalyse_1: {
color: 'info',
docs: '/docs/methods/WETSANALYSE',
publication: '/publicaties/wetsanalyse',
standard: '/publicaties/wetsanalyse',
},
Wetsanalyse_2: {
color: 'info',
demo: '/lab/jas-annotatie-tool/',
docs: '/docs/methods/WETSANALYSE',
publication: '/publicaties/wetsanalyse',
standard: '/publicaties/wetsanalyse',
},
} satisfies Record<string, MethodTree>;

Expand Down
Loading