Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: various fixes #10

Merged
merged 12 commits into from
Mar 26, 2024
Merged

chore: various fixes #10

merged 12 commits into from
Mar 26, 2024

Conversation

kantp
Copy link
Collaborator

@kantp kantp commented Mar 25, 2024 •
edited
Loading

This is implementing a couple of changes we had discussed on slack. In particular:

  • Moving the initialisation of the token contract to deploy.
  • Setting the tokenSymbol during initialisation.
  • Remove getAccountOf
  • Add a check that the total supply cannot be set lower than the currently circulating supply.
  • Allow changing the adminAccount
  • Removed Upgradable interface
  • Some cleanup and additional tests

@kantp kantp requested a review from qwadratic March 25, 2024 18:18
@kantp kantp force-pushed the kantp/initialisation branch from da9b191 to 4c9036a Compare March 25, 2024 18:26
@qwadratic
Copy link
Contributor

good stuff, but build is failing, hope it will be easy to fix

@kantp kantp marked this pull request as ready for review March 26, 2024 16:34
@kantp kantp merged commit 4cfa056 into develop Mar 26, 2024
6 checks passed
@harrysolovay harrysolovay deleted the kantp/initialisation branch March 29, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwadratic qwadratic qwadratic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kantp @qwadratic