Fix: Stashbox scene with invalid date value is created in Stash app w…

…ithout date instead of printing errors
MinasukiHikimuna · Aug 22, 2024 · 586250e · 586250e
1 parent 6f83c32
commit 586250e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 27 deletions.
diff --git a/plugins/CompleteTheStash/CompleteTheStash.yml b/plugins/CompleteTheStash/CompleteTheStash.yml
@@ -1,6 +1,6 @@
 name: CompleteTheStash
 description: Finds missing scenes for selected performers and creates missing scene metadata to another missing Stash instance. You can use either StashDB or TPDB or both as a source for missing scenes.
-version: 0.4.4
+version: 0.4.5
 url: https://github.com/MinasukiHikimuna/MidnightRider-Stash/
 exec:
   - python

diff --git a/plugins/CompleteTheStash/StashCompleter.py b/plugins/CompleteTheStash/StashCompleter.py
@@ -58,37 +58,32 @@ def create_scene(self, scene, performer_ids, studio_id):
             missing_tag = self.missing_stash_client.get_or_create_tag(tag["name"])
             tag_ids.append(missing_tag["id"])
 
+        new_scene = {
+            "title": title,
+            "code": code,
+            "details": scene["details"],
+            "url": studio_url,
+            "studio_id": studio_id,
+            "performer_ids": performer_ids,
+            "tag_ids": tag_ids,
+            "cover_image": cover_image,
+            "stash_ids": [
+                {
+                    "endpoint": self.config.get("stashboxEndpoint"),
+                    "stash_id": stash_id,
+                }
+            ],
+        }
+
         try:
-            # Ensure the date is in the correct format
             formatted_date = (
                 datetime.strptime(date, "%Y-%m-%d").date().isoformat() if date else None
             )
+            new_scene["date"] = formatted_date
         except ValueError:
-            self.logger.error(
-                f"Invalid date format for scene '{title}': {date} (Stashbox ID: {stash_id})"
-            )
-            return None
-
-        result = self.missing_stash_client.create_scene(
-            {
-                "title": title,
-                "code": code,
-                "details": scene["details"],
-                "url": studio_url,
-                "date": formatted_date,
-                "studio_id": studio_id,
-                "performer_ids": performer_ids,
-                "tag_ids": tag_ids,
-                "cover_image": cover_image,
-                "stash_ids": [
-                    {
-                        "endpoint": self.config.get("stashboxEndpoint"),
-                        "stash_id": stash_id,
-                    }
-                ],
-            }
-        )
+            pass
 
+        result = self.missing_stash_client.create_scene(new_scene)
         if result:
             return result["id"]
 
@@ -228,7 +223,9 @@ def process_performers(self):
                 ),
                 None,
             )
-            self.logger.debug(f"Performer {local_performer_name}: Stash ID {performer_stash_id}")
+            self.logger.debug(
+                f"Performer {local_performer_name}: Stash ID {performer_stash_id}"
+            )
             if not performer_stash_id:
                 self.logger.warning(
                     f"Performer {local_performer_name} does not have a Stashbox ID for endpoint {self.config.get('stashboxEndpoint')}. Skipping..."