-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: #184 Cleanup debug/log messages and styles #194
Conversation
…ng templates where not before.
…plates where not before in both example apps
@@ -3,7 +3,7 @@ | |||
"version": "0.0.0", | |||
"private": true, | |||
"scripts": { | |||
"start": "DEBUG=express-sample:server node ./bin/www" | |||
"start": "DEBUG=raygun,express-sample:server node ./bin/www" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes raygun debug messages show up in the Express sample app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw a couple of code formatting issues.
The only doubt I have is when should we use debug
and when should we use console.error
or console.log
.
Otherwise, this is good to go!
Co-authored-by: Miguel Beltran <[email protected]>
Co-authored-by: Miguel Beltran <[email protected]>
Fixed up a merge conflict and implemented Miguel's changes. Feel free to pull down and test locally @TheRealAgentK |
refactor: #184 (Cleanup debug/log)
Description 📝
Type of change
Delete options that are not relevant.
Updates
👉 All calls to
debug
now show the file the debug call was triggered by. This will help folks finding issues or going through the flow easier.👉 Enabled RG4N debug messages to show in the Express Sample app (via the
www
launcher script)👉 All
console...()
calls consistently track a prefix[Raygun4Node]
(or similar for examples) now👉 Changed console and debug calls to using string literal templates
Test plan 🧪
Internal refactor,
npm run tests
passes all and Express Sample app works correctly and as expectedAuthor to check 👓
Reviewer to check ✔️