Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raygun.messageBuilder.ts #206

Closed
wants to merge 1 commit into from
Closed

Update raygun.messageBuilder.ts #206

wants to merge 1 commit into from

Conversation

PanosNB
Copy link

@PanosNB PanosNB commented May 8, 2024

To avoid recursive cycles, an ancestor object could be referenced by more than one descend objects. So, always keep the ancestor object in the explored set

[{ticket number/type}:] {title}

Description 📝

  • Purpose: What issue does this PR address or what feature does it implement?
  • Approach: How does this PR tackle the problem?

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Updates

👉
👉
👉

Screenshots 📷

{Image here of before and after - if applicable}

Test plan 🧪

Provide guidance for how to QA your proposed changes. This is not only for a test but also useful for a reviewer.

{A test plan outlining scenarios to test}

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

To avoid recursive cycles, an ancestor object could be referenced by more than one descend objects. So, always keep the ancestor object in the explored set
Copy link

github-actions bot commented May 8, 2024

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:

No release type found in pull request title "Update raygun.messageBuilder.ts". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@PanosNB PanosNB closed this May 8, 2024
@PanosNB PanosNB deleted the PanosNB-patch-1 branch May 8, 2024 22:03
@PanosNB PanosNB restored the PanosNB-patch-1 branch May 9, 2024 01:54
@PanosNB PanosNB reopened this May 9, 2024
@PanosNB
Copy link
Author

PanosNB commented May 9, 2024

The code already handles this issue. My bad, I thought we were deleting from the _existing set

@PanosNB PanosNB closed this May 9, 2024
@PanosNB PanosNB deleted the PanosNB-patch-1 branch May 9, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant