Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Rails' new error handling API #178

Merged
merged 3 commits into from
May 4, 2024

Conversation

nikz
Copy link
Contributor

@nikz nikz commented May 2, 2024

If config.register_rails_error_handler is truthy, Raygun registers for errors via Rails.error.handle

See https://edgeguides.rubyonrails.org/error_reporting.html

If config.register_rails_error_handler is truthy, Raygun registers for
errors via `Rails.error.handle`

See https://edgeguides.rubyonrails.org/error_reporting.html
@nikz nikz requested a review from sumitramanga May 2, 2024 23:30
@nikz nikz self-assigned this May 2, 2024
Copy link
Collaborator

@sumitramanga sumitramanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! I'd be keen to test this out before a full release goes out 🚀

Copy link
Collaborator

@sumitramanga sumitramanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few tests failing so it would be good to fix those bad boys up first :)

* Ensure we're waiting for futures after each test
* Reset to a known good state before suite
* Reset configuration in a standard manner
* Fix to breadcrumbs triggering failsafe
@nikz nikz dismissed sumitramanga’s stale review May 4, 2024 01:37

Got tests passing!

@nikz nikz merged commit c6a5037 into MindscapeHQ:master May 4, 2024
12 checks passed
@nikz nikz deleted the support-rails-error-handle branch May 4, 2024 01:37
@sumitramanga
Copy link
Collaborator

I'm happy with these changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants